RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:07:35 +00:00
Code Issues Activity Actions

LibWeb: Make Element::has_attribute_ns take a StringView

Browse source 
Similar to Element::has_attribute, ideally this would take a
`FlyString const&`, but NamedNodeMap::get_attribute_ns already takes a
StringView. To aid in porting away from DeprecatedString, just take a
StringView for now.
This commit is contained in:
Shannon Booth 2023-10-01 15:10:40 +13:00 • committed by Andreas Kling
parent eaa6304aab
commit e5e4920e66
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -310,7 +310,7 @@ bool Element::has_attribute(StringView name) const
} }
// https://dom.spec.whatwg.org/#dom-element-hasattributens // https://dom.spec.whatwg.org/#dom-element-hasattributens
bool Element::has_attribute_ns(DeprecatedFlyString namespace_, DeprecatedFlyString const& name) const bool Element::has_attribute_ns(StringView namespace_, StringView name) const
{ {
// 1. If namespace is the empty string, then set it to null. // 1. If namespace is the empty string, then set it to null.
if (namespace_.is_empty()) if (namespace_.is_empty())

2
Userland/Libraries/LibWeb/DOM/Element.h
View file

@ -93,7 +93,7 @@ public:
// FIXME: This should be taking a 'FlyString const&' // FIXME: This should be taking a 'FlyString const&'
bool has_attribute(StringView name) const; bool has_attribute(StringView name) const;
bool has_attribute_ns(DeprecatedFlyString namespace_, DeprecatedFlyString const& name) const; bool has_attribute_ns(StringView namespace_, StringView name) const;
bool has_attributes() const; bool has_attributes() const;
// FIXME: This should be taking a 'FlyString const&' // FIXME: This should be taking a 'FlyString const&'