RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 06:28:13 +00:00
Code Issues Activity Actions

LibWeb: Respect offsets always when painting with object-position

Browse source 
Previously we didn't always set the bitmap_intersect correctly when
applying an object-position. This lead to images not correctly being
centered when the axis that it should move along was not the specified
axis.
This commit is contained in:
Tobias Christiansen 2023-10-30 16:15:29 +01:00 • committed by Andreas Kling
parent 6f71b8be1b
commit e60253d64c
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Painting/ImagePaintable.cpp
View file

@ -141,10 +141,9 @@ void ImagePaintable::paint(PaintContext& context, PaintPhase phase) const
offset_x = (double)residual_horizontal - (double)(residual_horizontal)*offset.percentage().as_fraction();
else
offset_x = residual_horizontal - offset.length().to_px(layout_node()).to_int();
if (image_int_rect.width() < scaled_bitmap_width)
bitmap_intersect.set_x(-(offset_x / scale_x));
}
if (image_int_rect.width() < scaled_bitmap_width)
bitmap_intersect.set_x(-(offset_x / scale_x));
}
auto offset_y = 0;
@ -164,10 +163,9 @@ void ImagePaintable::paint(PaintContext& context, PaintPhase phase) const
offset_y = (double)residual_vertical - (double)(residual_vertical)*offset.percentage().as_fraction();
else
offset_y = residual_vertical - offset.length().to_px(layout_node()).to_int();
if (image_int_rect.height() < scaled_bitmap_height)
bitmap_intersect.set_y(-(offset_y / scale_y));
}
if (image_int_rect.height() < scaled_bitmap_height)
bitmap_intersect.set_y(-(offset_y / scale_y));
}
Gfx::IntRect draw_rect = {