From e615af886e233543a387e831b0517fb947f2ab59 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Fri, 26 Aug 2022 00:52:57 +0200 Subject: [PATCH] LibGL: Report color buffer bits instead of texture bits For `GL_RED_BITS`, `GL_GREEN_BITS`, `GL_BLUE_BITS` and `GL_ALPHA_BITS` we were reporting the values we use in LibSoftGPU for textures. This fixes these context parameters to actually report the color buffer bits. --- Userland/Libraries/LibGL/ContextParameter.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibGL/ContextParameter.cpp b/Userland/Libraries/LibGL/ContextParameter.cpp index c35048c7bd..0598e1d2cf 100644 --- a/Userland/Libraries/LibGL/ContextParameter.cpp +++ b/Userland/Libraries/LibGL/ContextParameter.cpp @@ -15,7 +15,7 @@ Optional GLContext::get_context_parameter(GLenum name) { switch (name) { case GL_ALPHA_BITS: - return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(float) * 8 } }; + return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(u8) * 8 } }; case GL_ALPHA_TEST: return ContextParameter { .type = GL_BOOL, .is_capability = true, .value = { .boolean_value = m_alpha_test_enabled } }; case GL_BLEND: @@ -25,7 +25,7 @@ Optional GLContext::get_context_parameter(GLenum name) case GL_BLEND_SRC_ALPHA: return ContextParameter { .type = GL_INT, .value = { .integer_value = static_cast(m_blend_source_factor) } }; case GL_BLUE_BITS: - return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(float) * 8 } }; + return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(u8) * 8 } }; case GL_COLOR_MATERIAL: return ContextParameter { .type = GL_BOOL, .is_capability = true, .value = { .boolean_value = m_color_material_enabled } }; case GL_COLOR_MATERIAL_FACE: @@ -47,7 +47,7 @@ Optional GLContext::get_context_parameter(GLenum name) return ContextParameter { .type = GL_BOOL, .is_capability = true, .value = { .boolean_value = fog_enabled } }; } case GL_GREEN_BITS: - return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(float) * 8 } }; + return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(u8) * 8 } }; case GL_LIGHTING: return ContextParameter { .type = GL_BOOL, .is_capability = true, .value = { .boolean_value = m_lighting_enabled } }; case GL_LINE_SMOOTH: @@ -91,7 +91,7 @@ Optional GLContext::get_context_parameter(GLenum name) case GL_POLYGON_OFFSET_FILL: return ContextParameter { .type = GL_BOOL, .is_capability = true, .value = { .boolean_value = m_depth_offset_enabled } }; case GL_RED_BITS: - return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(float) * 8 } }; + return ContextParameter { .type = GL_INT, .value = { .integer_value = sizeof(u8) * 8 } }; case GL_SCISSOR_BOX: { auto scissor_box = m_rasterizer->options().scissor_box; return ContextParameter {