RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:47:34 +00:00
Code Issues Activity Actions

Kernel: Remove big lock from sys$connect

Browse source 
This syscall doesn't access any unprotected shared data.
This commit is contained in:
Idan Horowitz 2022-04-09 22:51:14 +03:00 • committed by Andreas Kling
parent 9547a8e8a2
commit e620487b66
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -55,7 +55,7 @@ enum class NeedsBigProcessLock {
S(clock_nanosleep, NeedsBigProcessLock::No) \ S(clock_nanosleep, NeedsBigProcessLock::No) \
S(clock_settime, NeedsBigProcessLock::No) \ S(clock_settime, NeedsBigProcessLock::No) \
S(close, NeedsBigProcessLock::No) \ S(close, NeedsBigProcessLock::No) \
S(connect, NeedsBigProcessLock::Yes) \ S(connect, NeedsBigProcessLock::No) \
S(create_inode_watcher, NeedsBigProcessLock::Yes) \ S(create_inode_watcher, NeedsBigProcessLock::Yes) \
S(create_thread, NeedsBigProcessLock::Yes) \ S(create_thread, NeedsBigProcessLock::Yes) \
S(dbgputstr, NeedsBigProcessLock::No) \ S(dbgputstr, NeedsBigProcessLock::No) \

2
Kernel/Syscalls/socket.cpp
View file

@ -145,7 +145,7 @@ ErrorOr<FlatPtr> Process::sys$accept4(Userspace<Syscall::SC_accept4_params const
ErrorOr<FlatPtr> Process::sys$connect(int sockfd, Userspace<sockaddr const*> user_address, socklen_t user_address_size) ErrorOr<FlatPtr> Process::sys$connect(int sockfd, Userspace<sockaddr const*> user_address, socklen_t user_address_size)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) VERIFY_NO_PROCESS_BIG_LOCK(this)
auto description = TRY(open_file_description(sockfd)); auto description = TRY(open_file_description(sockfd));
if (!description->is_socket()) if (!description->is_socket())