RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:27:45 +00:00
Code Issues Activity Actions

LibDebug: Propagate errors throughout DWARF parsing

Browse source 
Splitting this into a separate commit was an afterthought, so this does
not yet feature any fallible operations.
This commit is contained in:
Tim Schumacher 2023-01-22 00:32:08 +01:00 • committed by Andreas Kling
parent e235c42e4d
commit e62269650a
17 changed files with 243 additions and 204 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibSymbolication/Symbolication.cpp
View file

@ -105,7 +105,7 @@ Optional<Symbol> symbolicate(DeprecatedString const& path, FlatPtr address, Incl
Vector<Debug::DebugInfo::SourcePosition> positions;
if (include_source_positions == IncludeSourcePosition::Yes) {
auto source_position_with_inlines = cached_elf->debug_info->get_source_position_with_inlines(address);
auto source_position_with_inlines = cached_elf->debug_info->get_source_position_with_inlines(address).release_value_but_fixme_should_propagate_errors();
for (auto& position : source_position_with_inlines.inline_chain) {
if (!positions.contains_slow(position))