RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

Fix broken SpinLock.

Browse source 
The SpinLock was all backwards and didn't actually work. Fixing it exposed
how wrong most of the locking here is.

I need to come up with a better granularity here.
This commit is contained in:
Andreas Kling 2018-10-29 21:54:11 +01:00
parent bea106fdb2
commit e6284a8774
24 changed files with 195 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Kernel/Task.cpp
View file

@ -17,6 +17,7 @@
//#define DEBUG_IO
//#define TASK_DEBUG
//#define SCHEDULER_DEBUG
#define VALIDATE_USER_BUFFER(b, s) \
do { \
@ -605,12 +606,12 @@ bool scheduleNewTask()
}
}
#if 0
kprintf("Scheduler choices:\n");
#ifdef SCHEDULER_DEBUG
dbgprintf("Scheduler choices:\n");
for (auto* task = s_tasks->head(); task; task = task->next()) {
if (task->state() == Task::BlockedWait || task->state() == Task::BlockedSleep)
continue;
kprintf("%w %s(%u)\n", task->state(), task->name().characters(), task->pid());
//if (task->state() == Task::BlockedWait || task->state() == Task::BlockedSleep)
// continue;
dbgprintf("%w %s(%u)\n", task->state(), task->name().characters(), task->pid());
}
#endif
@ -621,7 +622,9 @@ bool scheduleNewTask()
auto* task = s_tasks->head();
if (task->state() == Task::Runnable || task->state() == Task::Running) {
//kprintf("switch to %s (%p vs %p)\n", task->name().characters(), task, current);
#ifdef SCHEDULER_DEBUG
dbgprintf("switch to %s(%u) (%p vs %p)\n", task->name().characters(), task->pid(), task, current);
#endif
return contextSwitch(task);
}
@ -844,7 +847,7 @@ int Task::sys$open(const char* path, int options)
if (m_fileHandles.size() >= m_maxFileHandles)
return -EMFILE;
int error;
auto handle = VirtualFileSystem::the().open(path, error, 0, cwdInode());
auto handle = VirtualFileSystem::the().open(path, error, options, cwdInode());
if (!handle)
return error;
if (options & O_DIRECTORY && !handle->isDirectory())