From e649ff5d31c7fedb88e295f8a21da343187a4116 Mon Sep 17 00:00:00 2001
From: Timothy Flynn <trflynn89@pm.me>
Date: Thu, 10 Feb 2022 17:58:55 -0500
Subject: [PATCH] LibSQL: Return a not-yet-implemented error for unimplemented
 expressions

Easier to debug than returning a NULL value.
---
 Userland/Libraries/LibSQL/AST/AST.h          | 5 ++++-
 Userland/Libraries/LibSQL/AST/Expression.cpp | 5 -----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/Userland/Libraries/LibSQL/AST/AST.h b/Userland/Libraries/LibSQL/AST/AST.h
index ed07b69c0b..092ecff1f8 100644
--- a/Userland/Libraries/LibSQL/AST/AST.h
+++ b/Userland/Libraries/LibSQL/AST/AST.h
@@ -305,7 +305,10 @@ struct ExecutionContext {
 
 class Expression : public ASTNode {
 public:
-    virtual ResultOr<Value> evaluate(ExecutionContext&) const;
+    virtual ResultOr<Value> evaluate(ExecutionContext&) const
+    {
+        return Result { SQLCommand::Unknown, SQLErrorCode::NotYetImplemented };
+    }
 };
 
 class ErrorExpression final : public Expression {
diff --git a/Userland/Libraries/LibSQL/AST/Expression.cpp b/Userland/Libraries/LibSQL/AST/Expression.cpp
index 2d48cfcadb..7183d1e521 100644
--- a/Userland/Libraries/LibSQL/AST/Expression.cpp
+++ b/Userland/Libraries/LibSQL/AST/Expression.cpp
@@ -12,11 +12,6 @@ namespace SQL::AST {
 
 static const String s_posix_basic_metacharacters = ".^$*[]+\\";
 
-ResultOr<Value> Expression::evaluate(ExecutionContext&) const
-{
-    return Value::null();
-}
-
 ResultOr<Value> NumericLiteral::evaluate(ExecutionContext&) const
 {
     Value ret(SQLType::Float);