RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:27:35 +00:00
Code Issues Activity Actions

LibJS: Do not use the $ special character in file names

Browse source 
The dollar sign is a special character in POSIX shells and in the Ninja
build file format. If the file name contains a `$`, something goes wrong
in the escaping/unescaping of this symbol, and CMake/GCC/Clang generate
invalid dependency files where not all instances of `$` are escaped
properly. Because of this, Ninja fails to rebuild `$262Object.cpp` if
the headers included by it have changed.

Stale `$262Object.cpp.o` files have been the cause of mysterious crashes
multiple times which only go away after doing a clean build. Let's
prevent these from happening again by removing the `$` from the
filename.
This commit is contained in:
Daniel Bertalan 2023-07-15 13:38:57 +02:00 • committed by Tim Flynn
parent 2b46e6f664
commit e64a8751d1
7 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Meta/gn/secondary/Userland/Libraries/LibJS/BUILD.gn
View file

@ -36,10 +36,10 @@ shared_library("LibJS") {
"Bytecode/RegexTable.cpp",
"Bytecode/StringTable.cpp",
"Console.cpp",
"Contrib/Test262/262Object.cpp",
"Contrib/Test262/AgentObject.cpp",
"Contrib/Test262/GlobalObject.cpp",
"Contrib/Test262/IsHTMLDDA.cpp",
"Contrib/Test262/\$262Object.cpp",
"CyclicModule.cpp",
"Heap/BlockAllocator.cpp",
"Heap/Cell.cpp",