RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:17:44 +00:00
Code Issues Activity Actions

LibWeb: Give Paintable its own pointer to the corresponding DOM node

Browse source 
Instead of going through the layout node's DOM pointer.
This commit is contained in:
Andreas Kling 2023-08-18 13:01:45 +02:00
parent 216bd513fa
commit e67ac16862
3 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Painting/Paintable.h
View file

@ -131,8 +131,9 @@ public:
Layout::Node const& layout_node() const { return m_layout_node; }
Layout::Node& layout_node() { return const_cast<Layout::Node&>(*m_layout_node); }
DOM::Node* dom_node() { return layout_node().dom_node(); }
DOM::Node const* dom_node() const { return layout_node().dom_node(); }
[[nodiscard]] JS::GCPtr<DOM::Node> dom_node();
[[nodiscard]] JS::GCPtr<DOM::Node const> dom_node() const;
void set_dom_node(JS::GCPtr<DOM::Node>);
auto const& computed_values() const { return m_layout_node->computed_values(); }
@ -164,6 +165,7 @@ protected:
virtual void visit_edges(Cell::Visitor&) override;
private:
JS::GCPtr<DOM::Node> m_dom_node;
JS::NonnullGCPtr<Layout::Node const> m_layout_node;
Optional<JS::GCPtr<Layout::Box const>> mutable m_containing_block;
};