RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:58:11 +00:00
Code Issues Activity Actions

LibWeb/WebDriver: Handle WindowProxy in internal_json_clone_algorithm()

Browse source 
To test:

```console
curl http://0.0.0.0:8000/session \
  -H 'Content-Type: application/json' \
  -d '{"capabilities": {}}'
curl http://0.0.0.0:8000/session/0/execute/sync \
  -H 'Content-Type: application/json' \
  -d '{"script": "return window;", "args": []}'
```

Which should result in:

```json
{
  "value": {
    "window-fcc6-11e5-b4f8-330a88ab9d7f":
    "86307df6-e2f1-4175-85cb-77295ff90898"
  }
}
```
This commit is contained in:
Linus Groh 2023-04-20 17:41:32 +01:00 • committed by Tim Flynn
parent 84a231d4e5
commit e6be5c37c0
8 changed files with 88 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View file

@ -27,6 +27,7 @@
#include <LibWeb/HTML/Scripting/Environments.h>
#include <LibWeb/HTML/Window.h>
#include <LibWeb/Page/Page.h>
#include <LibWeb/WebDriver/Contexts.h>
#include <LibWeb/WebDriver/ExecuteScript.h>
namespace Web::WebDriver {
@ -104,10 +105,22 @@ static ErrorOr<JsonValue, ExecuteScriptResultType> internal_json_clone_algorithm
if (value.is_bigint() || value.is_symbol())
return ExecuteScriptResultType::JavaScriptError;
// FIXME: - a collection
// FIXME: - instance of element
// FIXME: - instance of shadow root
// FIXME: - a WindowProxy object
// FIXME: -> a collection
// FIXME: -> instance of element
// FIXME: -> instance of shadow root
// -> a WindowProxy object
if (is<HTML::WindowProxy>(value.as_object())) {
auto const& window_proxy = static_cast<HTML::WindowProxy&>(value.as_object());
// If the associated browsing context of the WindowProxy object in value has been discarded, return error with
// error code stale element reference.
if (window_proxy.associated_browsing_context()->has_been_discarded())
return ExecuteScriptResultType::BrowsingContextDiscarded;
// Otherwise return success with data set to WindowProxy reference object for value.
return window_proxy_reference_object(window_proxy);
}
// -> has an own property named "toJSON" that is a Function
auto to_json = value.as_object().get_without_side_effects(vm.names.toJSON);