RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:38:11 +00:00
Code Issues Activity Actions

LibUnicode: Generate *_from_string methods using a hash map

Browse source 
Rather than a long series of string comparisons, generate each of these
methods using a hash map of the enumeration name to its value.
This commit is contained in:
Timothy Flynn 2021-08-10 09:04:47 -04:00 • committed by Andreas Kling
parent 5ac23d244d
commit e6e462249f
1 changed files with 29 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

86
Userland/Libraries/LibUnicode/CodeGenerators/GenerateUnicodeData.cpp
View file

@ -554,6 +554,7 @@ static void generate_unicode_data_implementation(Core::File& file, UnicodeData c
#include <AK/BinarySearch.h> #include <AK/BinarySearch.h>
#include <AK/CharacterTypes.h> #include <AK/CharacterTypes.h>
#include <AK/HashMap.h> #include <AK/HashMap.h>
#include <AK/String.h>
#include <AK/StringView.h> #include <AK/StringView.h>
#include <LibUnicode/UnicodeData.h> #include <LibUnicode/UnicodeData.h>
@ -774,74 +775,45 @@ bool code_point_has_@enum_snake@(u32 code_point, @enum_title@ @enum_snake@)
)~~~"); )~~~");
}; };
append_prop_search("GeneralCategory"sv, "general_category"sv, "s_general_categories"sv); auto append_from_string = [&](StringView enum_title, StringView enum_snake, PropList const& prop_list, Vector<Alias> const& aliases) {
generator.set("enum_title", enum_title);
generator.set("enum_snake", enum_snake);
generator.append(R"~~~( auto properties = prop_list.keys();
Optional<GeneralCategory> general_category_from_string(StringView const& general_category) for (auto const& alias : aliases)
{)~~~"); properties.append(alias.alias);
quick_sort(properties);
for (auto const& general_category : unicode_data.general_categories) {
generator.set("general_category", general_category.key);
generator.append(R"~~~( generator.append(R"~~~(
if (general_category == "@general_category@"sv) Optional<@enum_title@> @enum_snake@_from_string(StringView const& @enum_snake@)
return GeneralCategory::@general_category@;)~~~"); {
} static HashMap<String, @enum_title@> @enum_snake@_values { {)~~~");
for (auto const& alias : unicode_data.general_category_aliases) {
generator.set("general_category", alias.alias);
generator.append(R"~~~(
if (general_category == "@general_category@"sv)
return GeneralCategory::@general_category@;)~~~");
}
generator.append(R"~~~( for (auto const& property : properties) {
generator.set("property", property);
generator.append(R"~~~(
{ "@property@"sv, @enum_title@::@property@ },)~~~");
}
generator.append(R"~~~(
} };
if (auto value = @enum_snake@_values.get(@enum_snake@); value.has_value())
return value.value();
return {}; return {};
} }
)~~~"); )~~~");
};
append_prop_search("GeneralCategory"sv, "general_category"sv, "s_general_categories"sv);
append_from_string("GeneralCategory"sv, "general_category"sv, unicode_data.general_categories, unicode_data.general_category_aliases);
append_prop_search("Property"sv, "property"sv, "s_properties"sv); append_prop_search("Property"sv, "property"sv, "s_properties"sv);
append_from_string("Property"sv, "property"sv, unicode_data.prop_list, unicode_data.prop_aliases);
append_from_string("Script"sv, "script"sv, unicode_data.script_list, unicode_data.script_aliases);
generator.append(R"~~~( generator.append(R"~~~(
Optional<Property> property_from_string(StringView const& property)
{
if (property == "Assigned"sv)
return Property::Assigned;)~~~");
for (auto const& property : unicode_data.prop_list) {
generator.set("property", property.key);
generator.append(R"~~~(
if (property == "@property@"sv)
return Property::@property@;)~~~");
}
for (auto const& alias : unicode_data.prop_aliases) {
generator.set("property", alias.alias);
generator.append(R"~~~(
if (property == "@property@"sv)
return Property::@property@;)~~~");
}
generator.append(R"~~~(
return {};
}
Optional<Script> script_from_string(StringView const& script)
{)~~~");
for (auto const& script : unicode_data.script_list) {
generator.set("script", script.key);
generator.append(R"~~~(
if (script == "@script@"sv)
return Script::@script@;)~~~");
}
for (auto const& alias : unicode_data.script_aliases) {
generator.set("script", alias.alias);
generator.append(R"~~~(
if (script == "@script@"sv)
return Script::@script@;)~~~");
}
generator.append(R"~~~(
return {};
}
} }