RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

Kernel: Add two error checks for open() to return EISDIR or ENODEV.

Browse source
This commit is contained in:
Andreas Kling 2019-03-06 20:27:19 +01:00
parent 7d46375690
commit e6f389a544
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/VirtualFileSystem.cpp
View file

@ -189,12 +189,17 @@ RetainPtr<FileDescriptor> VFS::open(const String& path, int& error, int options,
error = -EACCES; error = -EACCES;
return nullptr; return nullptr;
} }
if (metadata.is_directory()) {
error = -EISDIR;
return nullptr;
}
} }
if (metadata.is_device()) { if (metadata.is_device()) {
auto it = m_devices.find(encoded_device(metadata.major_device, metadata.minor_device)); auto it = m_devices.find(encoded_device(metadata.major_device, metadata.minor_device));
if (it == m_devices.end()) { if (it == m_devices.end()) {
kprintf("VFS::open: no such device %u,%u\n", metadata.major_device, metadata.minor_device); kprintf("VFS::open: no such device %u,%u\n", metadata.major_device, metadata.minor_device);
error = -ENODEV;
return nullptr; return nullptr;
} }
auto descriptor = (*it).value->open(error, options); auto descriptor = (*it).value->open(error, options);