1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00

AK: Simplify constructors and conversions from nullptr_t

Problem:
- Many constructors are defined as `{}` rather than using the ` =
  default` compiler-provided constructor.
- Some types provide an implicit conversion operator from `nullptr_t`
  instead of requiring the caller to default construct. This violates
  the C++ Core Guidelines suggestion to declare single-argument
  constructors explicit
  (https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit).

Solution:
- Change default constructors to use the compiler-provided default
  constructor.
- Remove implicit conversion operators from `nullptr_t` and change
  usage to enforce type consistency without conversion.
This commit is contained in:
Lenny Maiorani 2021-01-10 16:29:28 -07:00 committed by Andreas Kling
parent 9dc44bf8c4
commit e6f907a155
105 changed files with 300 additions and 244 deletions

View file

@ -38,8 +38,8 @@ class Utf32CodepointIterator {
friend class Utf32View;
public:
Utf32CodepointIterator() { }
~Utf32CodepointIterator() { }
Utf32CodepointIterator() = default;
~Utf32CodepointIterator() = default;
bool operator==(const Utf32CodepointIterator& other) const
{
@ -83,7 +83,7 @@ class Utf32View {
public:
using Iterator = Utf32CodepointIterator;
Utf32View() { }
Utf32View() = default;
Utf32View(const u32* code_points, size_t length)
: m_code_points(code_points)
, m_length(length)