RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:57:45 +00:00
Code Issues Activity Actions

LibCoredump: Copy out the FooInfo structs to an aligned address

Browse source 
We were handing out unaligned pointers to these, which made UBSAN super
mad, copy them out to avoid that.
This commit is contained in:
Ali Mohammad Pur 2022-01-27 14:20:10 +03:30 • committed by Linus Groh
parent e0db9cb876
commit e72521f286
5 changed files with 56 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibCoredump/Backtrace.cpp
View file

@ -17,7 +17,7 @@
namespace Coredump {
ELFObjectInfo const* Backtrace::object_info_for_region(ELF::Core::MemoryRegionInfo const& region)
ELFObjectInfo const* Backtrace::object_info_for_region(MemoryRegionInfo const& region)
{
auto path = region.object_name();
if (!path.starts_with('/') && Core::File::looks_like_shared_library(path))
@ -99,8 +99,8 @@ Backtrace::~Backtrace()
void Backtrace::add_entry(const Reader& coredump, FlatPtr ip)
{
auto* ip_region = coredump.region_containing(ip);
if (!ip_region) {
auto ip_region = coredump.region_containing(ip);
if (!ip_region.has_value()) {
m_entries.append({ ip, {}, {}, {} });
return;
}
@ -116,7 +116,7 @@ void Backtrace::add_entry(const Reader& coredump, FlatPtr ip)
// the PT_LOAD header for the .text segment isn't the first one
// in the object file.
auto region = coredump.first_region_for_object(object_name);
auto* object_info = object_info_for_region(*region);
auto object_info = object_info_for_region(*region);
if (!object_info)
return;