From e72b14ef1d5907d9f52d49b8af9d1ee7fff4122a Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 25 Jan 2024 14:15:50 +0000 Subject: [PATCH] HackStudio: Correct DeclarationsModel::row_count() calculation No indices contain other indices, so the row count is 0 if the index is valid. This stops us infinitely recursing into non-existent indices. --- Userland/DevTools/HackStudio/DeclarationsModel.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Userland/DevTools/HackStudio/DeclarationsModel.h b/Userland/DevTools/HackStudio/DeclarationsModel.h index ee75fd8e2e..c7bbf8b9cd 100644 --- a/Userland/DevTools/HackStudio/DeclarationsModel.h +++ b/Userland/DevTools/HackStudio/DeclarationsModel.h @@ -38,7 +38,14 @@ public: Filename, __Column_Count, }; - virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return m_declarations.size(); } + + virtual int row_count(GUI::ModelIndex const& index = GUI::ModelIndex()) const override + { + if (!index.is_valid()) + return m_declarations.size(); + return 0; + } + virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return Column::__Column_Count; } virtual GUI::Variant data(GUI::ModelIndex const& index, GUI::ModelRole role) const override;