RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:17:35 +00:00
Code Issues Activity Actions

Profiler: Render signposts behind histograms

Browse source 
Since signposts render along the full height they could hide CPU usage
spikes. This way that won't be an issue. :^)
This commit is contained in:
Simon Wanner 2022-03-24 11:56:46 +01:00 • committed by Andreas Kling
parent 3d80d38954
commit e72f59cd23
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/DevTools/Profiler/TimelineTrack.cpp
View file

@ -64,6 +64,16 @@ void TimelineTrack::paint_event(GUI::PaintEvent& event)
float column_width = this->column_width(); float column_width = this->column_width();
float frame_height = (float)frame_inner_rect().height() / (float)m_max_value; float frame_height = (float)frame_inner_rect().height() / (float)m_max_value;
for_each_signpost([&](auto& signpost) {
int x = (int)((float)(signpost.timestamp - start_of_trace) * column_width);
int y1 = frame_thickness();
int y2 = height() - frame_thickness() * 2;
painter.draw_line({ x, y1 }, { x, y2 }, Color::Magenta);
return IterationDecision::Continue;
});
for (size_t bucket = 0; bucket < m_kernel_histogram->size(); bucket++) { for (size_t bucket = 0; bucket < m_kernel_histogram->size(); bucket++) {
auto kernel_value = m_kernel_histogram->at(bucket); auto kernel_value = m_kernel_histogram->at(bucket);
auto user_value = m_user_histogram->at(bucket); auto user_value = m_user_histogram->at(bucket);
@ -93,16 +103,6 @@ void TimelineTrack::paint_event(GUI::PaintEvent& event)
int select_hover_x = (int)((float)(normalized_hover_time - start_of_trace) * column_width); int select_hover_x = (int)((float)(normalized_hover_time - start_of_trace) * column_width);
painter.fill_rect({ select_start_x, frame_thickness(), select_end_x - select_start_x, height() - frame_thickness() * 2 }, Color(0, 0, 0, 60)); painter.fill_rect({ select_start_x, frame_thickness(), select_end_x - select_start_x, height() - frame_thickness() * 2 }, Color(0, 0, 0, 60));
painter.fill_rect({ select_hover_x, frame_thickness(), 1, height() - frame_thickness() * 2 }, Color::NamedColor::Black); painter.fill_rect({ select_hover_x, frame_thickness(), 1, height() - frame_thickness() * 2 }, Color::NamedColor::Black);
for_each_signpost([&](auto& signpost) {
int x = (int)((float)(signpost.timestamp - start_of_trace) * column_width);
int y1 = frame_thickness();
int y2 = height() - frame_thickness() * 2;
painter.draw_line({ x, y1 }, { x, y2 }, Color::Magenta);
return IterationDecision::Continue;
});
} }
template<typename Callback> template<typename Callback>