From e751ec2089cf980c434473f98e4e62323c1bdd61 Mon Sep 17 00:00:00 2001 From: Rodrigo Tobar Date: Sat, 7 Jan 2023 21:27:46 +0800 Subject: [PATCH] LibPDF: Avoid reading fields from moved-from Data object This might not be an issue at the moment, but moved-from objects are usually in a unspecifed but valid state, meaning that we shouldn't read from them. --- Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp | 2 +- Userland/Libraries/LibPDF/Fonts/Type1Font.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp b/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp index 9c94329d43..85c5799ca0 100644 --- a/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp +++ b/Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp @@ -40,7 +40,7 @@ PDFErrorOr> TrueTypeFont::create(Document* document, Nonn TrueTypeFont::TrueTypeFont(PDFFont::CommonData data) : m_data(data) { - m_is_standard_font = data.is_standard_font; + m_is_standard_font = m_data.is_standard_font; } u32 TrueTypeFont::char_code_to_code_point(u16 char_code) const diff --git a/Userland/Libraries/LibPDF/Fonts/Type1Font.cpp b/Userland/Libraries/LibPDF/Fonts/Type1Font.cpp index 67f1b17512..50df919e55 100644 --- a/Userland/Libraries/LibPDF/Fonts/Type1Font.cpp +++ b/Userland/Libraries/LibPDF/Fonts/Type1Font.cpp @@ -49,7 +49,7 @@ PDFErrorOr> Type1Font::create(Document* document, Nonnu Type1Font::Type1Font(Data data) : m_data(move(data)) { - m_is_standard_font = data.is_standard_font; + m_is_standard_font = m_data.is_standard_font; } u32 Type1Font::char_code_to_code_point(u16 char_code) const