RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 23:58:11 +00:00
Code Issues Activity Actions

FileManager+LibGUI: Cache the FileSystem::can_delete_or_move value

Browse source 
Add the function FileSystemModel::Node::can_delete_or_move which will
cache the result of FileSystem::can_delete_or_move for a node. This
prevents having to make system calls repeatedly to obtain this
information.

Fixes #18399
This commit is contained in:
Tom 2023-04-16 14:15:10 -06:00 • committed by Linus Groh
parent d824d07784
commit e758545b91
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/FileManager/DirectoryView.cpp
View file

@ -547,7 +547,7 @@ bool DirectoryView::can_modify_current_selection()
// FIXME: remove once Clang formats this properly.
// clang-format off
return selections.first_matching([&](auto& index) {
return FileSystem::can_delete_or_move(node(index).full_path());
return node(index).can_delete_or_move();
}).has_value();
// clang-format on
}

7
Userland/Libraries/LibGUI/FileSystemModel.cpp
View file

@ -159,6 +159,13 @@ void FileSystemModel::Node::traverse_if_needed()
}
}
bool FileSystemModel::Node::can_delete_or_move() const
{
if (!m_can_delete_or_move.has_value())
m_can_delete_or_move = FileSystem::can_delete_or_move(full_path());
return m_can_delete_or_move.value();
}
OwnPtr<FileSystemModel::Node> FileSystemModel::Node::create_child(DeprecatedString const& child_name)
{
DeprecatedString child_path = LexicalPath::join(full_path(), child_name).string();

3
Userland/Libraries/LibGUI/FileSystemModel.h
View file

@ -69,6 +69,8 @@ public:
int error() const { return m_error; }
char const* error_string() const { return strerror(m_error); }
bool can_delete_or_move() const;
DeprecatedString full_path() const;
private:
@ -83,6 +85,7 @@ public:
Node* m_parent { nullptr };
Vector<NonnullOwnPtr<Node>> m_children;
mutable Optional<bool> m_can_delete_or_move;
bool m_has_traversed { false };
bool m_selected { false };