RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-31 15:37:47 +00:00
Code Issues Activity Actions

AK: Remove infallible version of StringBuilder::to_byte_buffer

Browse source 
Also drop the try_ prefix from the fallible function, as it is no longer
needed to distinguish the two.
This commit is contained in:
Linus Groh 2023-03-09 15:00:14 +00:00
parent ad5e8f2742
commit e76394d96c
13 changed files with 21 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/StringBuilder.cpp
View file

@ -105,15 +105,9 @@ void StringBuilder::append_repeated(char ch, size_t n)
MUST(try_append_repeated(ch, n));
}
ByteBuffer StringBuilder::to_byte_buffer() const
ErrorOr<ByteBuffer> StringBuilder::to_byte_buffer() const
{
// FIXME: Handle OOM failure.
return ByteBuffer::copy(data(), length()).release_value_but_fixme_should_propagate_errors();
}
ErrorOr<ByteBuffer> StringBuilder::try_to_byte_buffer() const
{
return TRY(ByteBuffer::copy(data(), length()));
return ByteBuffer::copy(data(), length());
}
#ifndef KERNEL

3
AK/StringBuilder.h
View file

@ -68,8 +68,7 @@ public:
ErrorOr<String> to_string() const;
ErrorOr<FlyString> to_fly_string() const;
[[nodiscard]] ByteBuffer to_byte_buffer() const;
[[nodiscard]] ErrorOr<ByteBuffer> try_to_byte_buffer() const;
[[nodiscard]] ErrorOr<ByteBuffer> to_byte_buffer() const;
[[nodiscard]] StringView string_view() const;
void clear();