RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:37:34 +00:00
Code Issues Activity Actions

AK: Remove infallible version of StringBuilder::to_byte_buffer

Browse source 
Also drop the try_ prefix from the fallible function, as it is no longer
needed to distinguish the two.
This commit is contained in:
Linus Groh 2023-03-09 15:00:14 +00:00
parent ad5e8f2742
commit e76394d96c
13 changed files with 21 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCore/MimeData.cpp
View file

@ -38,7 +38,7 @@ ErrorOr<void> MimeData::set_urls(Vector<URL> const& urls)
TRY(builder.try_append(url.to_deprecated_string()));
TRY(builder.try_append('\n'));
}
set_data("text/uri-list", TRY(builder.try_to_byte_buffer()));
set_data("text/uri-list", TRY(builder.to_byte_buffer()));
return {};
}

2
Userland/Libraries/LibGL/GLContext.cpp
View file

@ -952,7 +952,7 @@ ErrorOr<ByteBuffer> GLContext::build_extension_string()
TRY(string_builder.try_join(' ', extensions));
// Create null-terminated string
auto extensions_bytes = TRY(string_builder.try_to_byte_buffer());
auto extensions_bytes = TRY(string_builder.to_byte_buffer());
TRY(extensions_bytes.try_append(0));
return extensions_bytes;
}

2
Userland/Libraries/LibGUI/Model.cpp
View file

@ -125,7 +125,7 @@ RefPtr<Core::MimeData> Model::mime_data(ModelSelection const& selection) const
}
});
mime_data->set_data(drag_data_type(), data_builder.try_to_byte_buffer().release_value_but_fixme_should_propagate_errors());
mime_data->set_data(drag_data_type(), data_builder.to_byte_buffer().release_value_but_fixme_should_propagate_errors());
mime_data->set_text(text_builder.to_deprecated_string());
if (bitmap)
mime_data->set_data("image/x-raw-bitmap", bitmap->serialize_to_byte_buffer().release_value_but_fixme_should_propagate_errors());

2
Userland/Libraries/LibGemini/GeminiRequest.cpp
View file

@ -15,7 +15,7 @@ ErrorOr<ByteBuffer> GeminiRequest::to_raw_request() const
StringBuilder builder;
TRY(builder.try_append(m_url.to_deprecated_string()));
TRY(builder.try_append("\r\n"sv));
return builder.try_to_byte_buffer();
return builder.to_byte_buffer();
}
Optional<GeminiRequest> GeminiRequest::from_raw_request(ByteBuffer const& raw_request)

2
Userland/Libraries/LibHTTP/HttpRequest.cpp
View file

@ -72,7 +72,7 @@ ErrorOr<ByteBuffer> HttpRequest::to_raw_request() const
TRY(builder.try_append((char const*)m_body.data(), m_body.size()));
}
TRY(builder.try_append("\r\n"sv));
return builder.try_to_byte_buffer();
return builder.to_byte_buffer();
}
Optional<HttpRequest> HttpRequest::from_raw_request(ReadonlyBytes raw_request)

2
Userland/Libraries/LibIMAP/QuotedPrintable.cpp
View file

@ -80,7 +80,7 @@ ErrorOr<ByteBuffer> decode_quoted_printable(StringView input)
}
}
return output.try_to_byte_buffer();
return output.to_byte_buffer();
}
}

8
Userland/Libraries/LibWeb/WebDriver/Client.cpp
View file

@ -220,7 +220,7 @@ ErrorOr<void, Client::WrappedError> Client::on_ready_to_read()
break;
}
m_request = HTTP::HttpRequest::from_raw_request(TRY(builder.try_to_byte_buffer()));
m_request = HTTP::HttpRequest::from_raw_request(TRY(builder.to_byte_buffer()));
if (!m_request.has_value())
return {};
@ -278,7 +278,7 @@ ErrorOr<void, Client::WrappedError> Client::send_success_response(JsonValue resu
builder.appendff("Content-Length: {}\r\n", content.length());
builder.append("\r\n"sv);
auto builder_contents = TRY(builder.try_to_byte_buffer());
auto builder_contents = TRY(builder.to_byte_buffer());
TRY(m_socket->write(builder_contents));
while (!content.is_empty()) {
@ -319,8 +319,8 @@ ErrorOr<void, Client::WrappedError> Client::send_error_response(Error const& err
header_builder.appendff("Content-Length: {}\r\n", content_builder.length());
header_builder.append("\r\n"sv);
TRY(m_socket->write(TRY(header_builder.try_to_byte_buffer())));
TRY(m_socket->write(TRY(content_builder.try_to_byte_buffer())));
TRY(m_socket->write(TRY(header_builder.to_byte_buffer())));
TRY(m_socket->write(TRY(content_builder.to_byte_buffer())));
log_response(error.http_status);
return {};