RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 17:58:12 +00:00
Code Issues Activity Actions

LibJS: Port Value::to_primitive_string() to NonnullGCPtr

Browse source
This commit is contained in:
Linus Groh 2023-04-13 14:34:00 +02:00 • committed by Andreas Kling
parent 04198a29a8
commit e79f5b6e85
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -397,12 +397,12 @@ ErrorOr<String> Value::to_string_without_side_effects() const
}
}
ThrowCompletionOr<PrimitiveString*> Value::to_primitive_string(VM& vm)
ThrowCompletionOr<NonnullGCPtr<PrimitiveString>> Value::to_primitive_string(VM& vm)
{
if (is_string())
return &as_string();
return as_string();
auto string = TRY(to_string(vm));
return PrimitiveString::create(vm, move(string)).ptr();
return PrimitiveString::create(vm, move(string));
}
// 7.1.17 ToString ( argument ), https://tc39.es/ecma262/#sec-tostring
@ -1728,7 +1728,7 @@ ThrowCompletionOr<Value> add(VM& vm, Value lhs, Value rhs)
auto rhs_string = TRY(rhs_primitive.to_primitive_string(vm));
// iii. Return the string-concatenation of lstr and rstr.
return PrimitiveString::create(vm, *lhs_string, *rhs_string);
return PrimitiveString::create(vm, lhs_string, rhs_string);
}
// d. Set lval to lprim.