1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00

LibJS: Implement Temporal.PlainTime.prototype.getISOFields()

This commit is contained in:
Linus Groh 2021-07-29 23:59:02 +01:00
parent c7bef42975
commit e7c5c3d507
3 changed files with 68 additions and 0 deletions

View file

@ -38,6 +38,7 @@ void PlainTimePrototype::initialize(GlobalObject& global_object)
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.toPlainDateTime, to_plain_date_time, 1, attr);
define_native_function(vm.names.getISOFields, get_iso_fields, 0, attr);
define_native_function(vm.names.valueOf, value_of, 0, attr);
}
@ -163,6 +164,43 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::to_plain_date_time)
return create_temporal_date_time(global_object, temporal_date->iso_year(), temporal_date->iso_month(), temporal_date->iso_day(), temporal_time->iso_hour(), temporal_time->iso_minute(), temporal_time->iso_second(), temporal_time->iso_millisecond(), temporal_time->iso_microsecond(), temporal_time->iso_nanosecond(), temporal_date->calendar());
}
// 4.3.19 Temporal.PlainTime.prototype.getISOFields ( ), https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.getisofields
JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::get_iso_fields)
{
// 1. Let temporalTime be the this value.
// 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]).
auto* temporal_time = typed_this(global_object);
if (vm.exception())
return {};
// 3. Let fields be ! OrdinaryObjectCreate(%Object.prototype%).
auto* fields = Object::create(global_object, global_object.object_prototype());
// 4. Perform ! CreateDataPropertyOrThrow(fields, "calendar", temporalTime.[[Calendar]]).
fields->create_data_property_or_throw(vm.names.calendar, Value(&temporal_time->calendar()));
// 5. Perform ! CreateDataPropertyOrThrow(fields, "isoHour", 𝔽(temporalTime.[[ISOHour]])).
fields->create_data_property_or_throw(vm.names.isoHour, Value(temporal_time->iso_hour()));
// 6. Perform ! CreateDataPropertyOrThrow(fields, "isoMicrosecond", 𝔽(temporalTime.[[ISOMicrosecond]])).
fields->create_data_property_or_throw(vm.names.isoMicrosecond, Value(temporal_time->iso_microsecond()));
// 7. Perform ! CreateDataPropertyOrThrow(fields, "isoMillisecond", 𝔽(temporalTime.[[ISOMillisecond]])).
fields->create_data_property_or_throw(vm.names.isoMillisecond, Value(temporal_time->iso_millisecond()));
// 8. Perform ! CreateDataPropertyOrThrow(fields, "isoMinute", 𝔽(temporalTime.[[ISOMinute]])).
fields->create_data_property_or_throw(vm.names.isoMinute, Value(temporal_time->iso_minute()));
// 9. Perform ! CreateDataPropertyOrThrow(fields, "isoNanosecond", 𝔽(temporalTime.[[ISONanosecond]])).
fields->create_data_property_or_throw(vm.names.isoNanosecond, Value(temporal_time->iso_nanosecond()));
// 10. Perform ! CreateDataPropertyOrThrow(fields, "isoSecond", 𝔽(temporalTime.[[ISOSecond]])).
fields->create_data_property_or_throw(vm.names.isoSecond, Value(temporal_time->iso_second()));
// 11. Return fields.
return fields;
}
// 4.3.23 Temporal.PlainTime.prototype.valueOf ( ), https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.valueof
JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::value_of)
{

View file

@ -27,6 +27,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(microsecond_getter);
JS_DECLARE_NATIVE_FUNCTION(nanosecond_getter);
JS_DECLARE_NATIVE_FUNCTION(to_plain_date_time);
JS_DECLARE_NATIVE_FUNCTION(get_iso_fields);
JS_DECLARE_NATIVE_FUNCTION(value_of);
};

View file

@ -0,0 +1,29 @@
describe("normal behavior", () => {
test("length is 0", () => {
expect(Temporal.PlainTime.prototype.getISOFields).toHaveLength(0);
});
test("basic functionality", () => {
const plainTime = new Temporal.PlainTime(23, 53, 18, 123, 456, 789);
const fields = plainTime.getISOFields();
expect(fields).toEqual({
calendar: plainTime.calendar,
isoHour: 23,
isoMicrosecond: 456,
isoMillisecond: 123,
isoMinute: 53,
isoNanosecond: 789,
isoSecond: 18,
});
// Test field order
expect(Object.getOwnPropertyNames(fields)).toEqual([
"calendar",
"isoHour",
"isoMicrosecond",
"isoMillisecond",
"isoMinute",
"isoNanosecond",
"isoSecond",
]);
});
});