RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00
Code Issues Activity Actions

LibJS: Devirtualize and pack the bytecode stream :^)

Browse source 
This patch changes the LibJS bytecode to be a stream of instructions
packed one-after-the-other in contiguous memory, instead of a vector
of OwnPtr<Instruction>. This should be a lot more cache-friendly. :^)

Instructions are also devirtualized and instead have a type field
using a new Instruction::Type enum.

To iterate over a bytecode stream, one must now use
Bytecode::InstructionStreamIterator.
This commit is contained in:
Andreas Kling 2021-06-07 15:12:43 +02:00
parent 845f2826aa
commit e7d69c5d3c
11 changed files with 284 additions and 110 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibJS/Bytecode/Generator.cpp
View file

@ -31,9 +31,14 @@ OwnPtr<Block> Generator::generate(ASTNode const& node)
return move(generator.m_block);
}
void Generator::append(NonnullOwnPtr<Instruction> instruction)
void Generator::grow(size_t additional_size)
{
m_block->append({}, move(instruction));
m_block->grow(additional_size);
}
void* Generator::next_slot()
{
return m_block->next_slot();
}
Register Generator::allocate_register()
@ -44,7 +49,7 @@ Register Generator::allocate_register()
Label Generator::make_label() const
{
return Label { m_block->instructions().size() };
return Label { m_block->instruction_stream().size() };
}
Label Generator::nearest_continuable_scope() const