From e7db1992495b102e4c8ec78fe70c708f7b3dc6f3 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Fri, 23 Jun 2023 11:26:44 -0400 Subject: [PATCH] LibJS: Do not fail a test if the flags list is empty There are hundreds of test262 tests with the following metadata line: flags: [] Other engine runners are apparently able to ignore those lines, so we should as well. --- Tests/LibJS/test262-runner.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Tests/LibJS/test262-runner.cpp b/Tests/LibJS/test262-runner.cpp index b8a9f8fa95..558076c893 100644 --- a/Tests/LibJS/test262-runner.cpp +++ b/Tests/LibJS/test262-runner.cpp @@ -349,11 +349,6 @@ static Result extract_metadata(StringView source if (line.starts_with("flags:"sv)) { auto flags = parse_list(line); - if (flags.is_empty()) { - failed_message = DeprecatedString::formatted("Failed to find flags in '{}'", line); - break; - } - for (auto flag : flags) { if (flag == "raw"sv) { metadata.strict_mode = StrictMode::NoStrict;