RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:07:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Tests/LibWeb/Layout/expected/abspos-flex-container-with-auto-height.txt
View file

@ -1,14 +1,14 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x0 [BFC] children: not-inline
Box <body> at (9,9) content-size 512.859375x19.46875 positioned flex-container(column) [FFC] children: not-inline
BlockContainer <div> at (10,10) content-size 510.859375x17.46875 flex-item [BFC] children: inline
line 0 width: 510.859375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 60, rect: [10,10 510.859375x17.46875]
Box <body> at (9,9) content-size 512.859375x19 positioned flex-container(column) [FFC] children: not-inline
BlockContainer <div> at (10,10) content-size 510.859375x17 flex-item [BFC] children: inline
line 0 width: 510.859375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 60, rect: [10,10 510.859375x17]
"Diese Website nutzt Cookies und vergleichbare Funktionen zur"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x2] overflow: [8,8 514.859375x21.46875]
PaintableBox (Box<BODY>) [8,8 514.859375x21.46875]
PaintableWithLines (BlockContainer<DIV>) [9,9 512.859375x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x2] overflow: [8,8 514.859375x21]
PaintableBox (Box<BODY>) [8,8 514.859375x21]
PaintableWithLines (BlockContainer<DIV>) [9,9 512.859375x19]
TextPaintable (TextNode<#text>)