RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:37:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Layout/expected/abspos-flexbox-with-auto-height.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x18 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x0 children: not-inline
Box <nav> at (11,11) content-size 310.453125x19.46875 positioned flex-container(row) [FFC] children: not-inline
BlockContainer <div.item> at (12,12) content-size 308.453125x17.46875 flex-item [BFC] children: inline
line 0 width: 308.453125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 36, rect: [12,12 308.453125x17.46875]
Box <nav> at (11,11) content-size 310.453125x19 positioned flex-container(row) [FFC] children: not-inline
BlockContainer <div.item> at (12,12) content-size 308.453125x17 flex-item [BFC] children: inline
line 0 width: 308.453125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 36, rect: [12,12 308.453125x17]
"This should have a green background."
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x20] overflow: [1,1 798x30.46875]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x2] overflow: [10,10 312.453125x21.46875]
PaintableBox (Box<NAV>) [10,10 312.453125x21.46875]
PaintableWithLines (BlockContainer<DIV>.item) [11,11 310.453125x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x20] overflow: [1,1 798x30]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x2] overflow: [10,10 312.453125x21]
PaintableBox (Box<NAV>) [10,10 312.453125x21]
PaintableWithLines (BlockContainer<DIV>.item) [11,11 310.453125x19]
TextPaintable (TextNode<#text>)