RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:47:36 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/anonymous-wrappers-continue-to-inherit-style-after-change.txt
View file

@ -1,21 +1,21 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x89.84375 [BFC] children: not-inline
BlockContainer <body> at (8,21.4375) content-size 784x73.84375 children: not-inline
BlockContainer <h1> at (8,21.4375) content-size 784x34.9375 children: inline
line 0 width: 105.53125, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 6, rect: [8,21.4375 105.53125x34.9375]
BlockContainer <html> at (0,0) content-size 800x89.4375 [BFC] children: not-inline
BlockContainer <body> at (8,21.4375) content-size 784x73.4375 children: not-inline
BlockContainer <h1> at (8,21.4375) content-size 784x35 children: inline
line 0 width: 105.53125, height: 35, bottom: 35, baseline: 27.09375
frag 0 from TextNode start: 0, length: 6, rect: [8,21.4375 105.53125x35]
"header"
TextNode <#text>
BlockContainer <(anonymous)> at (8,77.8125) content-size 784x17.46875 children: inline
line 0 width: 212.125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 24, rect: [8,77.8125 212.125x17.46875]
BlockContainer <(anonymous)> at (8,77.875) content-size 784x17 children: inline
line 0 width: 212.125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 24, rect: [8,77.875 212.125x17]
"anonymously wrapped text"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x89.84375] overflow: [0,0 800x95.28125]
PaintableWithLines (BlockContainer<BODY>) [8,21.4375 784x73.84375]
PaintableWithLines (BlockContainer<H1>) [8,21.4375 784x34.9375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x89.4375] overflow: [0,0 800x94.875]
PaintableWithLines (BlockContainer<BODY>) [8,21.4375 784x73.4375]
PaintableWithLines (BlockContainer<H1>) [8,21.4375 784x35]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,77.8125 784x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,77.875 784x17]
TextPaintable (TextNode<#text>)