RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 06:37:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/block-and-inline/abspos-grid-with-definite-width.txt
View file

@ -1,25 +1,25 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x18 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x0 children: not-inline
Box <div.box> at (1,11) content-size 200x70.28125 positioned [GFC] children: not-inline
BlockContainer <(anonymous)> at (1,11) content-size 200x70.28125 [BFC] children: inline
line 0 width: 181.78125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 21, rect: [1,11 181.78125x17.46875]
Box <div.box> at (1,11) content-size 200x68 positioned [GFC] children: not-inline
BlockContainer <(anonymous)> at (1,11) content-size 200x68 [BFC] children: inline
line 0 width: 181.78125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 21, rect: [1,11 181.78125x17]
"Giveaways in Channels"
line 1 width: 149.4375, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 22, length: 16, rect: [1,28 149.4375x17.46875]
line 1 width: 149.4375, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 22, length: 16, rect: [1,28 149.4375x17]
"and Free Premium"
line 2 width: 181.78125, height: 18.40625, bottom: 53.34375, baseline: 13.53125
frag 0 from TextNode start: 39, length: 21, rect: [1,45 181.78125x17.46875]
line 2 width: 181.78125, height: 17, bottom: 51, baseline: 13.296875
frag 0 from TextNode start: 39, length: 21, rect: [1,45 181.78125x17]
"Giveaways in Channels"
line 3 width: 149.4375, height: 17.875, bottom: 70.28125, baseline: 13.53125
frag 0 from TextNode start: 61, length: 16, rect: [1,63 149.4375x17.46875]
line 3 width: 149.4375, height: 17, bottom: 68, baseline: 13.296875
frag 0 from TextNode start: 61, length: 16, rect: [1,62 149.4375x17]
"and Free Premium"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x20] overflow: [0,1 799x81.28125]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x2] overflow: [0,10 202x72.28125]
PaintableBox (Box<DIV>.box) [0,10 202x72.28125]
PaintableWithLines (BlockContainer(anonymous)) [1,11 200x70.28125]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x20] overflow: [0,1 799x79]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x2] overflow: [0,10 202x70]
PaintableBox (Box<DIV>.box) [0,10 202x70]
PaintableWithLines (BlockContainer(anonymous)) [1,11 200x68]
TextPaintable (TextNode<#text>)