1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:57:34 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -1,72 +1,72 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x34.9375 children: not-inline
BlockContainer <div> at (8,8) content-size 784x34.9375 children: not-inline
BlockContainer <body> at (8,8) content-size 784x34 children: not-inline
BlockContainer <div> at (8,8) content-size 784x34 children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 784x0 children: inline
TextNode <#text>
BlockContainer <div> at (8,8) content-size 784x0 children: inline
TextNode <#text>
BlockContainer <div.a> at (8,8) content-size 57.0625x34.9375 floating [BFC] children: not-inline
BlockContainer <div.a> at (8,8) content-size 57.0625x34 floating [BFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 57.0625x0 children: inline
TextNode <#text>
BlockContainer <div.a4> at (8,8) content-size 57.0625x17.46875 children: inline
line 0 width: 57.0625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 4, rect: [8,8 57.0625x17.46875]
BlockContainer <div.a4> at (8,8) content-size 57.0625x17 children: inline
line 0 width: 57.0625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 4, rect: [8,8 57.0625x17]
"AAAA"
TextNode <#text>
BlockContainer <(anonymous)> at (8,25.46875) content-size 57.0625x0 children: inline
BlockContainer <(anonymous)> at (8,25) content-size 57.0625x0 children: inline
TextNode <#text>
BlockContainer <div> at (8,25.46875) content-size 57.0625x17.46875 children: inline
line 0 width: 14.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,25.46875 14.265625x17.46875]
BlockContainer <div> at (8,25) content-size 57.0625x17 children: inline
line 0 width: 14.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,25 14.265625x17]
"A"
TextNode <#text>
BlockContainer <(anonymous)> at (8,42.9375) content-size 57.0625x0 children: inline
BlockContainer <(anonymous)> at (8,42) content-size 57.0625x0 children: inline
TextNode <#text>
TextNode <#text>
BlockContainer <(anonymous)> at (8,8) content-size 784x0 children: inline
TextNode <#text>
BlockContainer <div> at (108,8) content-size 684x34.9375 children: not-inline
BlockContainer <div> at (108,8) content-size 684x34 children: not-inline
BlockContainer <(anonymous)> at (108,8) content-size 684x0 children: inline
TextNode <#text>
BlockContainer <div> at (108,8) content-size 684x17.46875 children: inline
line 0 width: 9.34375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [108,8 9.34375x17.46875]
BlockContainer <div> at (108,8) content-size 684x17 children: inline
line 0 width: 9.34375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [108,8 9.34375x17]
"B"
TextNode <#text>
BlockContainer <(anonymous)> at (108,25.46875) content-size 684x0 children: inline
BlockContainer <(anonymous)> at (108,25) content-size 684x0 children: inline
TextNode <#text>
BlockContainer <div.c> at (108,25.46875) content-size 684x17.46875 [BFC] children: inline
line 0 width: 10.3125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [108,25.46875 10.3125x17.46875]
BlockContainer <div.c> at (108,25) content-size 684x17 [BFC] children: inline
line 0 width: 10.3125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [108,25 10.3125x17]
"C"
TextNode <#text>
BlockContainer <(anonymous)> at (108,42.9375) content-size 684x0 children: inline
BlockContainer <(anonymous)> at (108,42) content-size 684x0 children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,42.9375) content-size 784x0 children: inline
BlockContainer <(anonymous)> at (8,42) content-size 784x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34.9375]
PaintableWithLines (BlockContainer<DIV>) [8,8 784x34.9375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34]
PaintableWithLines (BlockContainer<DIV>) [8,8 784x34]
PaintableWithLines (BlockContainer(anonymous)) [8,8 784x0]
PaintableWithLines (BlockContainer<DIV>) [8,8 784x0]
PaintableWithLines (BlockContainer<DIV>.a) [8,8 57.0625x34.9375]
PaintableWithLines (BlockContainer<DIV>.a) [8,8 57.0625x34]
PaintableWithLines (BlockContainer(anonymous)) [8,8 57.0625x0]
PaintableWithLines (BlockContainer<DIV>.a4) [8,8 57.0625x17.46875]
PaintableWithLines (BlockContainer<DIV>.a4) [8,8 57.0625x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,25.46875 57.0625x0]
PaintableWithLines (BlockContainer<DIV>) [8,25.46875 57.0625x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [8,25 57.0625x0]
PaintableWithLines (BlockContainer<DIV>) [8,25 57.0625x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,42.9375 57.0625x0]
PaintableWithLines (BlockContainer(anonymous)) [8,42 57.0625x0]
PaintableWithLines (BlockContainer(anonymous)) [8,8 784x0]
PaintableWithLines (BlockContainer<DIV>) [108,8 684x34.9375]
PaintableWithLines (BlockContainer<DIV>) [108,8 684x34]
PaintableWithLines (BlockContainer(anonymous)) [108,8 684x0]
PaintableWithLines (BlockContainer<DIV>) [108,8 684x17.46875]
PaintableWithLines (BlockContainer<DIV>) [108,8 684x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [108,25.46875 684x0]
PaintableWithLines (BlockContainer<DIV>.c) [108,25.46875 684x17.46875]
PaintableWithLines (BlockContainer(anonymous)) [108,25 684x0]
PaintableWithLines (BlockContainer<DIV>.c) [108,25 684x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [108,42.9375 684x0]
PaintableWithLines (BlockContainer(anonymous)) [8,42.9375 784x0]
PaintableWithLines (BlockContainer(anonymous)) [108,42 684x0]
PaintableWithLines (BlockContainer(anonymous)) [8,42 784x0]