RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Tests/LibWeb/Layout/expected/block-and-inline/block-with-max-content-width.txt
View file

@ -1,37 +1,37 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x76.40625 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x58.40625 children: not-inline
BlockContainer <div.foo> at (11,11) content-size 150.21875x17.46875 children: inline
line 0 width: 150.21875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 18, rect: [11,11 150.21875x17.46875]
BlockContainer <html> at (1,1) content-size 798x75 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x57 children: not-inline
BlockContainer <div.foo> at (11,11) content-size 150.21875x17 children: inline
line 0 width: 150.21875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 18, rect: [11,11 150.21875x17]
"width: max-content"
TextNode <#text>
BlockContainer <(anonymous)> at (10,29.46875) content-size 780x0 children: inline
BlockContainer <(anonymous)> at (10,29) content-size 780x0 children: inline
TextNode <#text>
BlockContainer <div.bar> at (11,30.46875) content-size 187.953125x17.46875 children: inline
line 0 width: 187.953125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 22, rect: [11,30.46875 187.953125x17.46875]
BlockContainer <div.bar> at (11,30) content-size 187.953125x17 children: inline
line 0 width: 187.953125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 22, rect: [11,30 187.953125x17]
"max-width: max-content"
TextNode <#text>
BlockContainer <(anonymous)> at (10,48.9375) content-size 780x0 children: inline
BlockContainer <(anonymous)> at (10,48) content-size 780x0 children: inline
TextNode <#text>
BlockContainer <div.baz> at (11,49.9375) content-size 183.078125x17.46875 children: inline
line 0 width: 183.078125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 22, rect: [11,49.9375 183.078125x17.46875]
BlockContainer <div.baz> at (11,49) content-size 183.078125x17 children: inline
line 0 width: 183.078125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 22, rect: [11,49 183.078125x17]
"min-width: max-content"
TextNode <#text>
BlockContainer <(anonymous)> at (10,68.40625) content-size 780x0 children: inline
BlockContainer <(anonymous)> at (10,67) content-size 780x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x78.40625]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x60.40625]
PaintableWithLines (BlockContainer<DIV>.foo) [10,10 152.21875x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x77]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x59]
PaintableWithLines (BlockContainer<DIV>.foo) [10,10 152.21875x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [10,29.46875 780x0]
PaintableWithLines (BlockContainer<DIV>.bar) [10,29.46875 189.953125x19.46875]
PaintableWithLines (BlockContainer(anonymous)) [10,29 780x0]
PaintableWithLines (BlockContainer<DIV>.bar) [10,29 189.953125x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [10,48.9375 780x0]
PaintableWithLines (BlockContainer<DIV>.baz) [10,48.9375 185.078125x19.46875]
PaintableWithLines (BlockContainer(anonymous)) [10,48 780x0]
PaintableWithLines (BlockContainer<DIV>.baz) [10,48 185.078125x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [10,68.40625 780x0]
PaintableWithLines (BlockContainer(anonymous)) [10,67 780x0]