RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

44
Tests/LibWeb/Layout/expected/block-and-inline/button-baseline-align.txt
View file

@ -1,38 +1,38 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x47.671875 children: inline
line 0 width: 61.1875, height: 47.671875, bottom: 47.671875, baseline: 33.828125
frag 0 from BlockContainer start: 0, length: 0, rect: [8,8 61.1875x47.671875]
BlockContainer <div.ib> at (8,8) content-size 61.1875x47.671875 inline-block [BFC] children: inline
line 0 width: 61.1875, height: 47.671875, bottom: 47.671875, baseline: 33.828125
frag 0 from BlockContainer start: 0, length: 0, rect: [9,24 17.828125x21.84375]
frag 1 from TextNode start: 0, length: 1, rect: [28,28 8x17.46875]
BlockContainer <body> at (8,8) content-size 784x48 children: inline
line 0 width: 61.1875, height: 48, bottom: 48, baseline: 34
frag 0 from BlockContainer start: 0, length: 0, rect: [8,8 61.1875x48]
BlockContainer <div.ib> at (8,8) content-size 61.1875x48 inline-block [BFC] children: inline
line 0 width: 61.1875, height: 48, bottom: 48, baseline: 34
frag 0 from BlockContainer start: 0, length: 0, rect: [9,25 17.828125x22]
frag 1 from TextNode start: 0, length: 1, rect: [28,28 8x17]
" "
frag 2 from BlockContainer start: 0, length: 0, rect: [41,10 23.359375x43.671875]
frag 2 from BlockContainer start: 0, length: 0, rect: [41,10 23.359375x44]
TextNode <#text>
BlockContainer <div.label> at (9,24) content-size 17.828125x21.84375 inline-block [BFC] children: inline
line 0 width: 17.828125, height: 21.84375, bottom: 21.84375, baseline: 16.921875
frag 0 from TextNode start: 0, length: 1, rect: [9,24 17.828125x21.84375]
BlockContainer <div.label> at (9,25) content-size 17.828125x22 inline-block [BFC] children: inline
line 0 width: 17.828125, height: 22, bottom: 22, baseline: 17
frag 0 from TextNode start: 0, length: 1, rect: [9,25 17.828125x22]
"A"
TextNode <#text>
TextNode <#text>
BlockContainer <button> at (41,10) content-size 23.359375x43.671875 inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (41,10) content-size 23.359375x43.671875 flex-container(column) [FFC] children: not-inline
BlockContainer <(anonymous)> at (41,10) content-size 23.359375x43.671875 flex-item [BFC] children: inline
line 0 width: 23.359375, height: 43.671875, bottom: 43.671875, baseline: 33.828125
frag 0 from TextNode start: 0, length: 1, rect: [41,10 23.359375x43.671875]
BlockContainer <button> at (41,10) content-size 23.359375x44 inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (41,10) content-size 23.359375x44 flex-container(column) [FFC] children: not-inline
BlockContainer <(anonymous)> at (41,10) content-size 23.359375x44 flex-item [BFC] children: inline
line 0 width: 23.359375, height: 44, bottom: 44, baseline: 34
frag 0 from TextNode start: 0, length: 1, rect: [41,10 23.359375x44]
"B"
TextNode <#text>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x47.671875]
PaintableWithLines (BlockContainer<DIV>.ib) [8,8 61.1875x47.671875]
PaintableWithLines (BlockContainer<DIV>.label) [8,23 19.828125x23.84375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x48]
PaintableWithLines (BlockContainer<DIV>.ib) [8,8 61.1875x48]
PaintableWithLines (BlockContainer<DIV>.label) [8,24 19.828125x24]
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<BUTTON>) [36,8 33.359375x47.671875]
PaintableWithLines (BlockContainer(anonymous)) [41,10 23.359375x43.671875]
PaintableWithLines (BlockContainer(anonymous)) [41,10 23.359375x43.671875]
PaintableWithLines (BlockContainer<BUTTON>) [36,8 33.359375x48]
PaintableWithLines (BlockContainer(anonymous)) [41,10 23.359375x44]
PaintableWithLines (BlockContainer(anonymous)) [41,10 23.359375x44]
TextPaintable (TextNode<#text>)