RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Tests/LibWeb/Layout/expected/block-and-inline/button-should-have-vertically-aligned-content.txt
View file

@ -1,27 +1,27 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x200 children: inline
line 0 width: 76.6875, height: 200, bottom: 200, baseline: 71
line 0 width: 76.6875, height: 200, bottom: 200, baseline: 70.296875
frag 0 from BlockContainer start: 0, length: 0, rect: [22,19 48.6875x178]
TextNode <#text>
BlockContainer <button.button.border-black> at (22,19) content-size 48.6875x178 inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (22,19) content-size 48.6875x178 flex-container(column) [FFC] children: not-inline
BlockContainer <(anonymous)> at (22,29.265625) content-size 48.6875x157.46875 flex-item [BFC] children: not-inline
BlockContainer <(anonymous)> at (22,29.265625) content-size 48.6875x0 children: inline
BlockContainer <(anonymous)> at (22,29.5) content-size 48.6875x157 flex-item [BFC] children: not-inline
BlockContainer <(anonymous)> at (22,29.5) content-size 48.6875x0 children: inline
TextNode <#text>
BlockContainer <div.border-black> at (32,39.265625) content-size 28.6875x17.46875 children: inline
line 0 width: 28.6875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [32,39.265625 28.6875x17.46875]
BlockContainer <div.border-black> at (32,39.5) content-size 28.6875x17 children: inline
line 0 width: 28.6875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 1, length: 3, rect: [32,39.5 28.6875x17]
"one"
TextNode <#text>
BlockContainer <(anonymous)> at (22,66.734375) content-size 48.6875x0 children: inline
BlockContainer <(anonymous)> at (22,66.5) content-size 48.6875x0 children: inline
TextNode <#text>
BlockContainer <div.border-black> at (32,76.734375) content-size 28.6875x100 children: inline
line 0 width: 28.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 3, rect: [32,76.734375 28.4375x17.46875]
BlockContainer <div.border-black> at (32,76.5) content-size 28.6875x100 children: inline
line 0 width: 28.4375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 1, length: 3, rect: [32,76.5 28.4375x17]
"two"
TextNode <#text>
BlockContainer <(anonymous)> at (22,186.734375) content-size 48.6875x0 children: inline
BlockContainer <(anonymous)> at (22,186.5) content-size 48.6875x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
@ -29,11 +29,11 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x200]
PaintableWithLines (BlockContainer<BUTTON>.button.border-black) [8,8 76.6875x200]
PaintableWithLines (BlockContainer(anonymous)) [22,19 48.6875x178]
PaintableWithLines (BlockContainer(anonymous)) [22,29.265625 48.6875x157.46875]
PaintableWithLines (BlockContainer(anonymous)) [22,29.265625 48.6875x0]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,29.265625 48.6875x37.46875]
PaintableWithLines (BlockContainer(anonymous)) [22,29.5 48.6875x157]
PaintableWithLines (BlockContainer(anonymous)) [22,29.5 48.6875x0]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,29.5 48.6875x37]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [22,66.734375 48.6875x0]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,66.734375 48.6875x120]
PaintableWithLines (BlockContainer(anonymous)) [22,66.5 48.6875x0]
PaintableWithLines (BlockContainer<DIV>.border-black) [22,66.5 48.6875x120]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [22,186.734375 48.6875x0]
PaintableWithLines (BlockContainer(anonymous)) [22,186.5 48.6875x0]