RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Tests/LibWeb/Layout/expected/block-and-inline/button-with-after-pseudo.txt
View file

@ -1,23 +1,23 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x74.59375 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x58.59375 children: inline
line 0 width: 424.640625, height: 58.59375, bottom: 58.59375, baseline: 42.28125
frag 0 from BlockContainer start: 0, length: 0, rect: [13,10 414.640625x54.59375]
BlockContainer <button.button_button___eDCW> at (13,10) content-size 414.640625x54.59375 positioned inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 414.640625x54.59375 flex-container(column) [FFC] children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 414.640625x54.59375 flex-item [BFC] children: inline
line 0 width: 414.640625, height: 54.59375, bottom: 54.59375, baseline: 42.28125
frag 0 from TextNode start: 0, length: 14, rect: [13,10 414.640625x54.59375]
BlockContainer <html> at (0,0) content-size 800x75 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x59 children: inline
line 0 width: 424.640625, height: 59, bottom: 59, baseline: 42.484375
frag 0 from BlockContainer start: 0, length: 0, rect: [13,10 414.640625x55]
BlockContainer <button.button_button___eDCW> at (13,10) content-size 414.640625x55 positioned inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 414.640625x55 flex-container(column) [FFC] children: not-inline
BlockContainer <(anonymous)> at (13,10) content-size 414.640625x55 flex-item [BFC] children: inline
line 0 width: 414.640625, height: 55, bottom: 55, baseline: 42.484375
frag 0 from TextNode start: 0, length: 14, rect: [13,10 414.640625x55]
"See more games"
TextNode <#text>
BlockContainer <(anonymous)> at (9,9) content-size 422.640625x56.59375 positioned [BFC] children: inline
BlockContainer <(anonymous)> at (9,9) content-size 422.640625x57 positioned [BFC] children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x74.59375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x58.59375]
PaintableWithLines (BlockContainer<BUTTON>.button_button___eDCW) [8,8 424.640625x58.59375]
PaintableWithLines (BlockContainer(anonymous)) [13,10 414.640625x54.59375]
PaintableWithLines (BlockContainer(anonymous)) [13,10 414.640625x54.59375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x75]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x59]
PaintableWithLines (BlockContainer<BUTTON>.button_button___eDCW) [8,8 424.640625x59]
PaintableWithLines (BlockContainer(anonymous)) [13,10 414.640625x55]
PaintableWithLines (BlockContainer(anonymous)) [13,10 414.640625x55]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [9,9 422.640625x56.59375]
PaintableWithLines (BlockContainer(anonymous)) [9,9 422.640625x57]