RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:07:36 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/block-and-inline/clear-both-from-inline-formatting-context.txt
View file

@ -3,21 +3,21 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <body> at (8,8) content-size 784x0 children: not-inline
BlockContainer <div> at (8,8) content-size 784x0 children: inline
TextNode <#text>
BlockContainer <h1.left> at (8,29.4375) content-size 28.53125x34.9375 floating [BFC] children: inline
line 0 width: 28.53125, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 1, rect: [8,29.4375 28.53125x34.9375]
BlockContainer <h1.left> at (8,29.4375) content-size 28.53125x35 floating [BFC] children: inline
line 0 width: 28.53125, height: 35, bottom: 35, baseline: 27.09375
frag 0 from TextNode start: 0, length: 1, rect: [8,29.4375 28.53125x35]
"A"
TextNode <#text>
TextNode <#text>
BlockContainer <h1.right> at (773.3125,29.4375) content-size 18.6875x34.9375 floating [BFC] children: inline
line 0 width: 18.6875, height: 34.9375, bottom: 34.9375, baseline: 27.0625
frag 0 from TextNode start: 0, length: 1, rect: [773.3125,29.4375 18.6875x34.9375]
BlockContainer <h1.right> at (773.3125,29.4375) content-size 18.6875x35 floating [BFC] children: inline
line 0 width: 18.6875, height: 35, bottom: 35, baseline: 27.09375
frag 0 from TextNode start: 0, length: 1, rect: [773.3125,29.4375 18.6875x35]
"B"
TextNode <#text>
TextNode <#text>
BlockContainer <div.c> at (8,155.8125) content-size 11.5625x17.46875 floating [BFC] children: inline
line 0 width: 11.5625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,155.8125 11.5625x17.46875]
BlockContainer <div.c> at (8,155.875) content-size 11.5625x17 floating [BFC] children: inline
line 0 width: 11.5625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,155.875 11.5625x17]
"X"
TextNode <#text>
TextNode <#text>
@ -26,9 +26,9 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x0]
PaintableWithLines (BlockContainer<DIV>) [8,8 784x0]
PaintableWithLines (BlockContainer<H1>.left) [8,29.4375 28.53125x34.9375]
PaintableWithLines (BlockContainer<H1>.left) [8,29.4375 28.53125x35]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<H1>.right) [773.3125,29.4375 18.6875x34.9375]
PaintableWithLines (BlockContainer<H1>.right) [773.3125,29.4375 18.6875x35]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.c) [8,155.8125 11.5625x17.46875]
PaintableWithLines (BlockContainer<DIV>.c) [8,155.875 11.5625x17]
TextPaintable (TextNode<#text>)