RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:57:44 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/block-and-inline/float-3.txt
View file

@ -1,6 +1,6 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 780x119.46875 children: not-inline
BlockContainer <body> at (8,8) content-size 780x119 children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 780x0 children: inline
TextNode <#text>
BlockContainer <div#top> at (8,8) content-size 780x100 [BFC] children: inline
@ -11,31 +11,31 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,108) content-size 780x0 children: inline
TextNode <#text>
BlockContainer <div#bottom> at (9,109) content-size 778x17.46875 children: not-inline
BlockContainer <div#bottom> at (9,109) content-size 778x17 children: not-inline
BlockContainer <(anonymous)> at (9,109) content-size 778x0 children: inline
TextNode <#text>
TextNode <#text>
BlockContainer <div#text> at (9,109) content-size 778x17.46875 children: inline
line 0 width: 54.796875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [371,109 54.796875x17.46875]
BlockContainer <div#text> at (9,109) content-size 778x17 children: inline
line 0 width: 54.796875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [371,109 54.796875x17]
"foobar"
TextNode <#text>
BlockContainer <(anonymous)> at (9,126.46875) content-size 778x0 children: inline
BlockContainer <(anonymous)> at (9,126) content-size 778x0 children: inline
TextNode <#text>
BlockContainer <(anonymous)> at (8,127.46875) content-size 780x0 children: inline
BlockContainer <(anonymous)> at (8,127) content-size 780x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 780x119.46875]
PaintableWithLines (BlockContainer<BODY>) [8,8 780x119]
PaintableWithLines (BlockContainer(anonymous)) [8,8 780x0]
PaintableWithLines (BlockContainer<DIV>#top) [8,8 780x100]
PaintableWithLines (BlockContainer<DIV>#top-left.box) [8,8 300x100]
PaintableWithLines (BlockContainer<DIV>#top-right.box) [488,8 300x100]
PaintableWithLines (BlockContainer(anonymous)) [8,108 780x0]
PaintableWithLines (BlockContainer<DIV>#bottom) [8,108 780x19.46875]
PaintableWithLines (BlockContainer<DIV>#bottom) [8,108 780x19]
PaintableWithLines (BlockContainer(anonymous)) [9,109 778x0]
PaintableWithLines (BlockContainer<DIV>#text) [9,109 778x17.46875]
PaintableWithLines (BlockContainer<DIV>#text) [9,109 778x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [9,126.46875 778x0]
PaintableWithLines (BlockContainer(anonymous)) [8,127.46875 780x0]
PaintableWithLines (BlockContainer(anonymous)) [9,126 778x0]
PaintableWithLines (BlockContainer(anonymous)) [8,127 780x0]