RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:47:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

42
Tests/LibWeb/Layout/expected/block-and-inline/inline-block-baseline-2.txt
View file

@ -1,39 +1,39 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x600 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 780x60.40625 children: inline
line 0 width: 144.375, height: 60.40625, bottom: 60.40625, baseline: 35
frag 0 from TextNode start: 0, length: 13, rect: [10,31 103.140625x17.46875]
BlockContainer <body> at (10,10) content-size 780x59 children: inline
line 0 width: 144.375, height: 59, bottom: 59, baseline: 34.296875
frag 0 from TextNode start: 0, length: 13, rect: [10,31 103.140625x17]
"Hello friends"
frag 1 from BlockContainer start: 0, length: 0, rect: [114,11 39.234375x58.40625]
frag 1 from BlockContainer start: 0, length: 0, rect: [114,11 39.234375x57]
TextNode <#text>
BlockContainer <div.ib> at (114,11) content-size 39.234375x58.40625 inline-block [BFC] children: not-inline
BlockContainer <div> at (115,12) content-size 37.234375x17.46875 children: inline
line 0 width: 22.546875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [115,12 22.546875x17.46875]
BlockContainer <div.ib> at (114,11) content-size 39.234375x57 inline-block [BFC] children: not-inline
BlockContainer <div> at (115,12) content-size 37.234375x17 children: inline
line 0 width: 22.546875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [115,12 22.546875x17]
"1st"
TextNode <#text>
BlockContainer <div> at (115,31.46875) content-size 37.234375x17.46875 children: inline
line 0 width: 26.28125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [115,31.46875 26.28125x17.46875]
BlockContainer <div> at (115,31) content-size 37.234375x17 children: inline
line 0 width: 26.28125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [115,31 26.28125x17]
"2nd"
TextNode <#text>
BlockContainer <div.float> at (115,50.9375) content-size 37.234375x17.46875 floating [BFC] children: inline
line 0 width: 37.234375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [115,50.9375 37.234375x17.46875]
BlockContainer <div.float> at (115,50) content-size 37.234375x17 floating [BFC] children: inline
line 0 width: 37.234375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 5, rect: [115,50 37.234375x17]
"float"
TextNode <#text>
BlockContainer <(anonymous)> at (114,49.9375) content-size 39.234375x0 children: inline
BlockContainer <(anonymous)> at (114,49) content-size 39.234375x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600] overflow: [0,0 800x602]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x602]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x62.40625]
PaintableWithLines (BlockContainer<BODY>) [9,9 782x61]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.ib) [113,10 41.234375x60.40625]
PaintableWithLines (BlockContainer<DIV>) [114,11 39.234375x19.46875]
PaintableWithLines (BlockContainer<DIV>.ib) [113,10 41.234375x59]
PaintableWithLines (BlockContainer<DIV>) [114,11 39.234375x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [114,30.46875 39.234375x19.46875]
PaintableWithLines (BlockContainer<DIV>) [114,30 39.234375x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.float) [114,49.9375 39.234375x19.46875]
PaintableWithLines (BlockContainer<DIV>.float) [114,49 39.234375x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [114,49.9375 39.234375x0]
PaintableWithLines (BlockContainer(anonymous)) [114,49 39.234375x0]