RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:27:44 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Tests/LibWeb/Layout/expected/block-and-inline/inline-box-positioned-with-top-left.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x20 children: inline
line 0 width: 352.34375, height: 20, bottom: 20, baseline: 13.53125
frag 0 from TextNode start: 0, length: 14, rect: [8,8 112.421875x17.46875]
line 0 width: 352.34375, height: 20, bottom: 20, baseline: 13.296875
frag 0 from TextNode start: 0, length: 14, rect: [8,8 112.421875x17]
"text text text"
frag 1 from BlockContainer start: 0, length: 0, rect: [120,8 110.375x20]
frag 2 from TextNode start: 0, length: 16, rect: [231,8 129.546875x17.46875]
frag 2 from TextNode start: 0, length: 16, rect: [231,8 129.546875x17]
"more inline text"
TextNode <#text>
BlockContainer <span.displaced_text> at (150,48) content-size 110.375x20 positioned inline-block [BFC] children: inline
line 0 width: 110.375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 14, rect: [150,48 110.375x17.46875]
line 0 width: 110.375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 14, rect: [150,48 110.375x17]
"displaced text"
TextNode <#text>
TextNode <#text>