RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 04:27:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/block-and-inline/margin-collapse-5.txt
View file

@ -1,19 +1,19 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x121.46875 [BFC] children: inline
line 0 width: 170.96875, height: 121.46875, bottom: 121.46875, baseline: 15.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [2,2 168.96875x119.46875]
BlockContainer <body> at (2,2) content-size 168.96875x119.46875 inline-block [BFC] children: not-inline
BlockContainer <div.hmm> at (3,3) content-size 166.96875x17.46875 children: inline
line 0 width: 166.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 21, rect: [3,3 166.96875x17.46875]
BlockContainer <html> at (1,1) content-size 798x121 [BFC] children: inline
line 0 width: 170.96875, height: 121, bottom: 121, baseline: 15.296875
frag 0 from BlockContainer start: 0, length: 0, rect: [2,2 168.96875x119]
BlockContainer <body> at (2,2) content-size 168.96875x119 inline-block [BFC] children: not-inline
BlockContainer <div.hmm> at (3,3) content-size 166.96875x17 children: inline
line 0 width: 166.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 21, rect: [3,3 166.96875x17]
"suspiciously tall box"
TextNode <#text>
BlockContainer <(anonymous)> at (2,121.46875) content-size 168.96875x0 children: inline
BlockContainer <(anonymous)> at (2,121) content-size 168.96875x0 children: inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x123.46875]
PaintableWithLines (BlockContainer<BODY>) [1,1 170.96875x121.46875]
PaintableWithLines (BlockContainer<DIV>.hmm) [2,2 168.96875x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x123]
PaintableWithLines (BlockContainer<BODY>) [1,1 170.96875x121]
PaintableWithLines (BlockContainer<DIV>.hmm) [2,2 168.96875x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [2,121.46875 168.96875x0]
PaintableWithLines (BlockContainer(anonymous)) [2,121 168.96875x0]