RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:27:34 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/LibWeb/Layout/expected/block-and-inline/margin-padding-block-inline-start.txt
View file

@ -1,18 +1,18 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x99.46875 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 500x81.46875 children: not-inline
BlockContainer <div.a> at (51,21) content-size 413x49.46875 children: not-inline
BlockContainer <div.b> at (92,32) content-size 326x17.46875 children: inline
line 0 width: 41.78125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [93,32 39.78125x17.46875]
BlockContainer <html> at (1,1) content-size 798x99 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 500x81 children: not-inline
BlockContainer <div.a> at (51,21) content-size 413x49 children: not-inline
BlockContainer <div.b> at (92,32) content-size 326x17 children: inline
line 0 width: 41.78125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 5, rect: [93,32 39.78125x17]
"Hello"
InlineNode <span>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x101.46875]
PaintableWithLines (BlockContainer<BODY>) [9,9 502x83.46875]
PaintableWithLines (BlockContainer<DIV>.a) [10,10 500x81.46875]
PaintableWithLines (BlockContainer<DIV>.b) [91,31 328x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x101]
PaintableWithLines (BlockContainer<BODY>) [9,9 502x83]
PaintableWithLines (BlockContainer<DIV>.a) [10,10 500x81]
PaintableWithLines (BlockContainer<DIV>.b) [91,31 328x19]
InlinePaintable (InlineNode<SPAN>)
TextPaintable (TextNode<#text>)