RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/block-and-inline/max-width-for-box-with-inline-children.txt
View file

@ -1,22 +1,22 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x185.96875 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 204x167.96875 children: not-inline
BlockContainer <div.outer> at (11,11) content-size 202x165.96875 children: not-inline
BlockContainer <div.inner> at (12,12) content-size 200x163.96875 children: inline
line 0 width: 88.765625, height: 54.59375, bottom: 54.59375, baseline: 42.28125
frag 0 from TextNode start: 0, length: 4, rect: [12,12 88.765625x54.59375]
BlockContainer <html> at (1,1) content-size 798x187 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 204x169 children: not-inline
BlockContainer <div.outer> at (11,11) content-size 202x167 children: not-inline
BlockContainer <div.inner> at (12,12) content-size 200x165 children: inline
line 0 width: 88.765625, height: 55, bottom: 55, baseline: 42.484375
frag 0 from TextNode start: 0, length: 4, rect: [12,12 88.765625x55]
"well"
line 1 width: 115.140625, height: 55.1875, bottom: 109.78125, baseline: 42.28125
frag 0 from TextNode start: 5, length: 5, rect: [12,66 115.140625x54.59375]
line 1 width: 115.140625, height: 55, bottom: 110, baseline: 42.484375
frag 0 from TextNode start: 5, length: 5, rect: [12,67 115.140625x55]
"hello"
line 2 width: 173, height: 54.78125, bottom: 163.96875, baseline: 42.28125
frag 0 from TextNode start: 11, length: 7, rect: [12,121 173x54.59375]
line 2 width: 173, height: 55, bottom: 165, baseline: 42.484375
frag 0 from TextNode start: 11, length: 7, rect: [12,122 173x55]
"friends"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x187.96875]
PaintableWithLines (BlockContainer<BODY>) [9,9 206x169.96875]
PaintableWithLines (BlockContainer<DIV>.outer) [10,10 204x167.96875]
PaintableWithLines (BlockContainer<DIV>.inner) [11,11 202x165.96875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x189]
PaintableWithLines (BlockContainer<BODY>) [9,9 206x171]
PaintableWithLines (BlockContainer<DIV>.outer) [10,10 204x169]
PaintableWithLines (BlockContainer<DIV>.inner) [11,11 202x167]
TextPaintable (TextNode<#text>)