RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/LibWeb/Layout/expected/block-and-inline/min-width-for-box-with-inline-children.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x76.59375 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 604x58.59375 children: not-inline
BlockContainer <div.outer> at (11,11) content-size 602x56.59375 children: not-inline
BlockContainer <div.inner> at (12,12) content-size 600x54.59375 children: inline
line 0 width: 426.90625, height: 54.59375, bottom: 54.59375, baseline: 42.28125
frag 0 from TextNode start: 0, length: 18, rect: [12,12 426.90625x54.59375]
BlockContainer <html> at (1,1) content-size 798x77 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 604x59 children: not-inline
BlockContainer <div.outer> at (11,11) content-size 602x57 children: not-inline
BlockContainer <div.inner> at (12,12) content-size 600x55 children: inline
line 0 width: 426.90625, height: 55, bottom: 55, baseline: 42.484375
frag 0 from TextNode start: 0, length: 18, rect: [12,12 426.90625x55]
"well hello friends"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x78.59375]
PaintableWithLines (BlockContainer<BODY>) [9,9 606x60.59375]
PaintableWithLines (BlockContainer<DIV>.outer) [10,10 604x58.59375]
PaintableWithLines (BlockContainer<DIV>.inner) [11,11 602x56.59375]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x79]
PaintableWithLines (BlockContainer<BODY>) [9,9 606x61]
PaintableWithLines (BlockContainer<DIV>.outer) [10,10 604x59]
PaintableWithLines (BlockContainer<DIV>.inner) [11,11 602x57]
TextPaintable (TextNode<#text>)