RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/block-and-inline/relpos-block.txt
View file

@ -1,21 +1,21 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (2,2) content-size 796x62.9375 [BFC] children: not-inline
BlockContainer <body> at (12,12) content-size 600x42.9375 children: not-inline
BlockContainer <div.exekiller> at (14,14) content-size 200x17.46875 positioned children: inline
line 0 width: 65.4375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 9, rect: [14,14 65.4375x17.46875]
BlockContainer <html> at (2,2) content-size 796x62 [BFC] children: not-inline
BlockContainer <body> at (12,12) content-size 600x42 children: not-inline
BlockContainer <div.exekiller> at (14,14) content-size 200x17 positioned children: inline
line 0 width: 65.4375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 9, rect: [14,14 65.4375x17]
"exekiller"
TextNode <#text>
BlockContainer <div.athena> at (24,25.46875) content-size 200x17.46875 positioned children: inline
line 0 width: 53.171875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [24,25.46875 53.171875x17.46875]
BlockContainer <div.athena> at (24,25) content-size 200x17 positioned children: inline
line 0 width: 53.171875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [24,25 53.171875x17]
"athena"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x66.9375]
PaintableWithLines (BlockContainer<BODY>) [10,10 604x46.9375]
PaintableWithLines (BlockContainer<DIV>.exekiller) [12,12 204x21.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x66]
PaintableWithLines (BlockContainer<BODY>) [10,10 604x46]
PaintableWithLines (BlockContainer<DIV>.exekiller) [12,12 204x21]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.athena) [22,23.46875 204x21.46875]
PaintableWithLines (BlockContainer<DIV>.athena) [22,23 204x21]
TextPaintable (TextNode<#text>)