RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:27:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/br-should-not-generate-pseudo-before.txt
View file

@ -1,29 +1,29 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x84.875 [BFC] children: not-inline
BlockContainer <body> at (8,16) content-size 784x68.875 children: not-inline
BlockContainer <p> at (8,16) content-size 784x17.46875 children: inline
line 0 width: 310.625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 1, rect: [8,16 10.625x17.46875]
BlockContainer <html> at (0,0) content-size 800x83 [BFC] children: not-inline
BlockContainer <body> at (8,16) content-size 784x67 children: not-inline
BlockContainer <p> at (8,16) content-size 784x17 children: inline
line 0 width: 310.625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 1, rect: [8,16 10.625x17]
"+"
frag 1 from TextNode start: 0, length: 36, rect: [19,16 300x17.46875]
frag 1 from TextNode start: 0, length: 36, rect: [19,16 300x17]
"P should generate a ::before pseudo."
InlineNode <(anonymous)>
TextNode <#text>
TextNode <#text>
BlockContainer <(anonymous)> at (8,49.46875) content-size 784x35.40625 children: inline
line 0 width: 0, height: 17.46875, bottom: 17.46875, baseline: 13.53125
line 1 width: 120.578125, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 0, length: 14, rect: [8,66.46875 120.578125x17.46875]
BlockContainer <(anonymous)> at (8,49) content-size 784x34 children: inline
line 0 width: 0, height: 17, bottom: 17, baseline: 13.296875
line 1 width: 120.578125, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 0, length: 14, rect: [8,66 120.578125x17]
"BR should not!"
BreakNode <br>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x84.875]
PaintableWithLines (BlockContainer<BODY>) [8,16 784x68.875]
PaintableWithLines (BlockContainer<P>) [8,16 784x17.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x83]
PaintableWithLines (BlockContainer<BODY>) [8,16 784x67]
PaintableWithLines (BlockContainer<P>) [8,16 784x17]
InlinePaintable (InlineNode(anonymous))
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,49.46875 784x35.40625]
PaintableWithLines (BlockContainer(anonymous)) [8,49 784x34]
TextPaintable (TextNode<#text>)