1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:47:35 +00:00

LibWeb: Bring CSS line-height closer to other engines

This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions

View file

@ -2,81 +2,81 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (100,0) content-size 700x832 [BFC] children: not-inline
BlockContainer <body> at (200,8) content-size 592x816 children: not-inline
BlockContainer <div> at (301,9) content-size 100x100 children: inline
line 0 width: 79.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 11, rect: [301,9 79.96875x17.46875]
line 0 width: 79.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 11, rect: [301,9 79.96875x17]
"Well, hello"
line 1 width: 59.21875, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 12, length: 8, rect: [301,26 59.21875x17.46875]
line 1 width: 59.21875, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 12, length: 8, rect: [301,26 59.21875x17]
"friends!"
TextNode <#text>
BlockContainer <(anonymous)> at (200,110) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (301,111) content-size 100x100 children: inline
line 0 width: 79.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 11, rect: [301,111 79.96875x17.46875]
line 0 width: 79.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 11, rect: [301,111 79.96875x17]
"Well, hello"
line 1 width: 59.21875, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 12, length: 8, rect: [301,128 59.21875x17.46875]
line 1 width: 59.21875, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 12, length: 8, rect: [301,128 59.21875x17]
"friends!"
TextNode <#text>
BlockContainer <(anonymous)> at (200,212) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (401,213) content-size 100x100 children: inline
line 0 width: 79.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 11, rect: [401,213 79.96875x17.46875]
line 0 width: 79.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 11, rect: [401,213 79.96875x17]
"Well, hello"
line 1 width: 59.21875, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 12, length: 8, rect: [401,230 59.21875x17.46875]
line 1 width: 59.21875, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 12, length: 8, rect: [401,230 59.21875x17]
"friends!"
TextNode <#text>
BlockContainer <(anonymous)> at (200,314) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (301,315) content-size 100x100 children: inline
line 0 width: 79.96875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 11, rect: [301,315 79.96875x17.46875]
line 0 width: 79.96875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 11, rect: [301,315 79.96875x17]
"Well, hello"
line 1 width: 59.21875, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 12, length: 8, rect: [301,332 59.21875x17.46875]
line 1 width: 59.21875, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 12, length: 8, rect: [301,332 59.21875x17]
"friends!"
TextNode <#text>
BlockContainer <(anonymous)> at (200,416) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (301,417) content-size 100x100 children: inline
line 0 width: 86.125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 26, rect: [301,417 86.125x17.46875]
line 0 width: 86.125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 26, rect: [301,417 86.125x17]
"حسنًا ، مرحباً"
line 1 width: 78.125, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 27, length: 25, rect: [301,434 78.125x17.46875]
line 1 width: 78.125, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 27, length: 25, rect: [301,434 78.125x17]
"أيها الأصدقاء"
TextNode <#text>
BlockContainer <(anonymous)> at (200,518) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (301,519) content-size 100x100 children: inline
line 0 width: 86.125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 26, rect: [301,519 86.125x17.46875]
line 0 width: 86.125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 26, rect: [301,519 86.125x17]
"حسنًا ، مرحباً"
line 1 width: 78.125, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 27, length: 25, rect: [301,536 78.125x17.46875]
line 1 width: 78.125, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 27, length: 25, rect: [301,536 78.125x17]
"أيها الأصدقاء"
TextNode <#text>
BlockContainer <(anonymous)> at (200,620) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (401,621) content-size 100x100 children: inline
line 0 width: 86.125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 26, rect: [401,621 86.125x17.46875]
line 0 width: 86.125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 26, rect: [401,621 86.125x17]
"حسنًا ، مرحباً"
line 1 width: 78.125, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 27, length: 25, rect: [401,638 78.125x17.46875]
line 1 width: 78.125, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 27, length: 25, rect: [401,638 78.125x17]
"أيها الأصدقاء"
TextNode <#text>
BlockContainer <(anonymous)> at (200,722) content-size 592x0 children: inline
TextNode <#text>
BlockContainer <div> at (401,723) content-size 100x100 children: inline
line 0 width: 86.125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 26, rect: [401,723 86.125x17.46875]
line 0 width: 86.125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 26, rect: [401,723 86.125x17]
"حسنًا ، مرحباً"
line 1 width: 78.125, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 27, length: 25, rect: [401,740 78.125x17.46875]
line 1 width: 78.125, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 27, length: 25, rect: [401,740 78.125x17]
"أيها الأصدقاء"
TextNode <#text>
BlockContainer <(anonymous)> at (200,824) content-size 592x0 children: inline