RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:47:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Tests/LibWeb/Layout/expected/css-font-size-calc.txt
View file

@ -1,12 +1,12 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x125.1875 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x109.1875 children: inline
line 0 width: 644.625, height: 109.1875, bottom: 109.1875, baseline: 84.578125
frag 0 from TextNode start: 0, length: 13, rect: [8,8 644.625x109.1875]
BlockContainer <html> at (0,0) content-size 800x125 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x109 children: inline
line 0 width: 644.625, height: 109, bottom: 109, baseline: 84.484375
frag 0 from TextNode start: 0, length: 13, rect: [8,8 644.625x109]
"Hello friends"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x125.1875]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x109.1875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x125]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x109]
TextPaintable (TextNode<#text>)