RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:17:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Layout/expected/css-font-size-math.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x78.609375 children: inline
line 0 width: 78.9375, height: 78.609375, bottom: 78.609375, baseline: 60.890625
frag 0 from TextNode start: 0, length: 1, rect: [8,25 39.09375x55.8125]
BlockContainer <body> at (8,8) content-size 784x79 children: inline
line 0 width: 78.9375, height: 79, bottom: 79, baseline: 61.09375
frag 0 from TextNode start: 0, length: 1, rect: [8,25 39.09375x56]
"H"
frag 1 from TextNode start: 0, length: 1, rect: [47,38 19.78125x39.625]
frag 1 from TextNode start: 0, length: 1, rect: [47,38 19.78125x40]
"e"
frag 2 from TextNode start: 0, length: 1, rect: [67,47 6.8125x28.125]
frag 2 from TextNode start: 0, length: 1, rect: [67,47 6.8125x28]
"l"
frag 3 from TextNode start: 0, length: 1, rect: [74,53 4.84375x19.96875]
frag 3 from TextNode start: 0, length: 1, rect: [74,53 4.84375x20]
"l"
frag 4 from TextNode start: 0, length: 1, rect: [79,57 8.40625x14.171875]
frag 4 from TextNode start: 0, length: 1, rect: [79,58 8.40625x14]
"o"
InlineNode <span>
TextNode <#text>
@ -26,7 +26,7 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x78.609375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x79]
InlinePaintable (InlineNode<SPAN>)
TextPaintable (TextNode<#text>)
InlinePaintable (InlineNode<SPAN>)