RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 04:17:34 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Tests/LibWeb/Layout/expected/dont-crash-on-relayout-that-rewraps-text.txt
View file

@ -1,27 +1,27 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x56.9375 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 200x38.9375 children: inline
line 0 width: 196.0625, height: 19.46875, bottom: 19.46875, baseline: 14.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 194.0625x17.46875]
line 1 width: 138.265625, height: 19.46875, bottom: 38.9375, baseline: 14.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [11,30 136.265625x17.46875]
BlockContainer <div> at (11,11) content-size 194.0625x17.46875 inline-block [BFC] children: inline
line 0 width: 194.0625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 20, rect: [11,11 194.0625x17.46875]
BlockContainer <html> at (1,1) content-size 798x56 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 200x38 children: inline
line 0 width: 196.0625, height: 19, bottom: 19, baseline: 14.296875
frag 0 from BlockContainer start: 0, length: 0, rect: [11,11 194.0625x17]
line 1 width: 138.265625, height: 19, bottom: 38, baseline: 14.296875
frag 0 from BlockContainer start: 0, length: 0, rect: [11,30 136.265625x17]
BlockContainer <div> at (11,11) content-size 194.0625x17 inline-block [BFC] children: inline
line 0 width: 194.0625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 20, rect: [11,11 194.0625x17]
"xxxxxxxxxxxxxxxxxxxx"
TextNode <#text>
TextNode <#text>
BlockContainer <div> at (11,30) content-size 136.265625x17.46875 inline-block [BFC] children: inline
line 0 width: 136.265625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 19, rect: [11,30 136.265625x17.46875]
BlockContainer <div> at (11,30) content-size 136.265625x17 inline-block [BFC] children: inline
line 0 width: 136.265625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 19, rect: [11,30 136.265625x17]
"yyyyyyyyyyyyyyyyyyy"
TextNode <#text>
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x58.9375]
PaintableWithLines (BlockContainer<BODY>) [9,9 202x40.9375]
PaintableWithLines (BlockContainer<DIV>) [10,10 196.0625x19.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x58]
PaintableWithLines (BlockContainer<BODY>) [9,9 202x40]
PaintableWithLines (BlockContainer<DIV>) [10,10 196.0625x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [10,29 138.265625x19.46875]
PaintableWithLines (BlockContainer<DIV>) [10,29 138.265625x19]
TextPaintable (TextNode<#text>)