RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Tests/LibWeb/Layout/expected/flex/br-element-does-not-get-blockified-by-itself.txt
View file

@ -1,16 +1,16 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x53.34375 children: not-inline
Box <div> at (8,8) content-size 784x53.34375 flex-container(row) [FFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 55.359375x53.34375 flex-item [BFC] children: inline
line 0 width: 28.40625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 1, length: 4, rect: [8,8 28.40625x17.46875]
BlockContainer <body> at (8,8) content-size 784x51 children: not-inline
Box <div> at (8,8) content-size 784x51 flex-container(row) [FFC] children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 55.359375x51 flex-item [BFC] children: inline
line 0 width: 28.40625, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 1, length: 4, rect: [8,8 28.40625x17]
"well"
line 1 width: 36.84375, height: 17.9375, bottom: 35.40625, baseline: 13.53125
frag 0 from TextNode start: 1, length: 5, rect: [8,25 36.84375x17.46875]
line 1 width: 36.84375, height: 17, bottom: 34, baseline: 13.296875
frag 0 from TextNode start: 1, length: 5, rect: [8,25 36.84375x17]
"hello"
line 2 width: 55.359375, height: 18.40625, bottom: 53.34375, baseline: 13.53125
frag 0 from TextNode start: 1, length: 7, rect: [8,42 55.359375x17.46875]
line 2 width: 55.359375, height: 17, bottom: 51, baseline: 13.296875
frag 0 from TextNode start: 1, length: 7, rect: [8,42 55.359375x17]
"friends"
TextNode <#text>
BreakNode <br>
@ -20,9 +20,9 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x53.34375]
PaintableBox (Box<DIV>) [8,8 784x53.34375]
PaintableWithLines (BlockContainer(anonymous)) [8,8 55.359375x53.34375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x51]
PaintableBox (Box<DIV>) [8,8 784x51]
PaintableWithLines (BlockContainer(anonymous)) [8,8 55.359375x51]
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)