RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:07:34 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Tests/LibWeb/Layout/expected/flex/flex-item-min-width-fit-content.txt
View file

@ -7,17 +7,17 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <(anonymous)> (not painted) [BFC] children: inline
TextNode <#text>
BlockContainer <div.buttons> at (394.625,11) content-size 114.375x50 flex-item [BFC] children: inline
line 0 width: 114.375, height: 19.46875, bottom: 19.46875, baseline: 14.53125
frag 0 from BlockContainer start: 0, length: 0, rect: [395.625,12 57.046875x17.46875]
frag 1 from BlockContainer start: 0, length: 0, rect: [454.625,12 53.328125x17.46875]
BlockContainer <div.button> at (395.625,12) content-size 57.046875x17.46875 inline-block [BFC] children: inline
line 0 width: 57.046875, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [395.625,12 57.046875x17.46875]
line 0 width: 114.375, height: 19, bottom: 19, baseline: 14.296875
frag 0 from BlockContainer start: 0, length: 0, rect: [395.625,12 57.046875x17]
frag 1 from BlockContainer start: 0, length: 0, rect: [454.625,12 53.328125x17]
BlockContainer <div.button> at (395.625,12) content-size 57.046875x17 inline-block [BFC] children: inline
line 0 width: 57.046875, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [395.625,12 57.046875x17]
"Accept"
TextNode <#text>
BlockContainer <div.button> at (454.625,12) content-size 53.328125x17.46875 inline-block [BFC] children: inline
line 0 width: 53.328125, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 6, rect: [454.625,12 53.328125x17.46875]
BlockContainer <div.button> at (454.625,12) content-size 53.328125x17 inline-block [BFC] children: inline
line 0 width: 53.328125, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 6, rect: [454.625,12 53.328125x17]
"Reject"
TextNode <#text>
@ -26,7 +26,7 @@ ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableBox (Box<BODY>) [9,9 502x54]
PaintableWithLines (BlockContainer<DIV>.big) [10,10 383.625x52]
PaintableWithLines (BlockContainer<DIV>.buttons) [393.625,10 116.375x52]
PaintableWithLines (BlockContainer<DIV>.button) [394.625,11 59.046875x19.46875]
PaintableWithLines (BlockContainer<DIV>.button) [394.625,11 59.046875x19]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>.button) [453.625,11 55.328125x19.46875]
PaintableWithLines (BlockContainer<DIV>.button) [453.625,11 55.328125x19]
TextPaintable (TextNode<#text>)