RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 17:17:45 +00:00
Code Issues Activity Actions

LibWeb: Bring CSS line-height closer to other engines

Browse source 
This patch makes a few changes to the way we calculate line-height:

- `line-height: normal` is now resolved using metrics from the used
  font (specifically, round(A + D + lineGap)).

- `line-height: calc(...)` is now resolved at style compute time.

- `line-height` values are now absolutized at style compute time.

As a consequence of the above, we no longer need to walk the DOM
ancestor chain looking for line-heights during style computation.
Instead, values are inherited, resolved and absolutized locally.

This is not only much faster, but also makes our line-height metrics
match those of other engines like Gecko and Blink.
This commit is contained in:
Andreas Kling 2024-01-12 12:39:40 +01:00
parent f0722671c3
commit e7de5cb4d2
385 changed files with 6889 additions and 6893 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Tests/LibWeb/Layout/expected/flex/list-container-display-contents.txt
View file

@ -1,23 +1,23 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x41.46875 [BFC] children: not-inline
BlockContainer <body> at (8,16) content-size 784x17.46875 children: not-inline
Box <ul.globalnav-list> at (48,16) content-size 744x17.46875 flex-container(row) [FFC] children: not-inline
BlockContainer <div#item-1> at (48,16) content-size 46.734375x17.46875 flex-item [BFC] children: inline
line 0 width: 46.734375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 5, rect: [48,16 46.734375x17.46875]
BlockContainer <html> at (0,0) content-size 800x41 [BFC] children: not-inline
BlockContainer <body> at (8,16) content-size 784x17 children: not-inline
Box <ul.globalnav-list> at (48,16) content-size 744x17 flex-container(row) [FFC] children: not-inline
BlockContainer <div#item-1> at (48,16) content-size 46.734375x17 flex-item [BFC] children: inline
line 0 width: 46.734375, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 5, rect: [48,16 46.734375x17]
"Store"
TextNode <#text>
BlockContainer <div#item-2> at (762,16) content-size 30x17.46875 flex-item [BFC] children: inline
line 0 width: 30, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [762,16 30x17.46875]
BlockContainer <div#item-2> at (762,16) content-size 30x17 flex-item [BFC] children: inline
line 0 width: 30, height: 17, bottom: 17, baseline: 13.296875
frag 0 from TextNode start: 0, length: 3, rect: [762,16 30x17]
"Mac"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x41.46875]
PaintableWithLines (BlockContainer<BODY>) [8,16 784x17.46875]
PaintableBox (Box<UL>.globalnav-list) [8,16 784x17.46875]
PaintableWithLines (BlockContainer<DIV>#item-1) [48,16 46.734375x17.46875]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x41]
PaintableWithLines (BlockContainer<BODY>) [8,16 784x17]
PaintableBox (Box<UL>.globalnav-list) [8,16 784x17]
PaintableWithLines (BlockContainer<DIV>#item-1) [48,16 46.734375x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>#item-2) [762,16 30x17.46875]
PaintableWithLines (BlockContainer<DIV>#item-2) [762,16 30x17]
TextPaintable (TextNode<#text>)